Makefile and indentation fixes #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent changes in speced/bikeshed#1635 also need to be reflected into the spec Makefiles.
|
Per https://www.python.org/dev/peps/pep-0008/#indentation we should probably use 4 spaces for *.py. |
Generally we seem to use 2-space indents, e.g. in the CSS of Encoding, or the JavaScript of Streams, or the .travis.yml files everywhere. It's only in the Bikeshed file that we use one-space indents. Additionally, per https://www.python.org/dev/peps/pep-0008/#indentation, Python files use four-space indents. This updates .editorconfig appropriately, and aligns .pr-preview.json files with this new default.
|
Force-pushed a commit that adds 4 spaces for |
domenic
added a commit
to whatwg/streams
that referenced
this pull request
Apr 14, 2020
domenic
added a commit
to whatwg/streams
that referenced
this pull request
Apr 14, 2020
|
The indentation looks wrong in the Makefile. Maybe we need .editorconfig for this repository as well. :-) Also, should I wait with this until the Streams thing is done? |
|
Force-pushed a fix to the Makefile No need to wait on Streams; that's still got some time left and I will probably just roll these changes in as part of it. |
|
I'll merge this, but I still need to look at tooling to make PRs to all repositories easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure about the default 2-space indents (vs. e.g. 4-space). The Python files in Encoding use 4-space, notably.