Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make local/remote need the COMMIT-SHA macro #8

Closed
andreubotella opened this issue Apr 23, 2020 · 1 comment
Closed

make local/remote need the COMMIT-SHA macro #8

andreubotella opened this issue Apr 23, 2020 · 1 comment

Comments

@andreubotella
Copy link
Member

The local and remote targets of the Makefile template define the SNAPSHOT-LINK text macro, which used to define the "snapshot as of this commit" link in the spec metadata. speced/bikeshed#1635, however, removed any usage of that macro, instead using a new COMMIT-SHA macro for the LS status, which those Makefile targets don't define.

This would be solved by removing the SNAPSHOT-LINK definition and adding one for COMMIT-SHA defining it to be the empty string, for example. However, this would create a link pointing to ./commit-snapshots//, which isn't ideal.

@annevk
Copy link
Member

annevk commented Apr 23, 2020

A bogus link is the plan in #7. I think that's fine personally. We don't support a full local deploy after all.

@annevk annevk closed this as completed Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants