Redesign fire an event and target override #344
Conversation
Fixes #187. Follow up work in HTML is tracked in whatwg/html#1713.
|
|
||
| <ol> | ||
| <li><p>Set <var>event</var>'s <a>dispatch flag</a>. | ||
|
|
||
| <li> | ||
| <p>If <var>targetOverride</var> is not given, let <var>targetOverride</var> be <var>target</var>. | ||
| <p>Let <var>targetOverride</var> be <var>target</var>, if <var>legacy target override flag</var> |
There was a problem hiding this comment.
Nit: I think "the legacy target override flag" is more consistent with what we've done so far.
There was a problem hiding this comment.
Not in my prose... (Aside: I'm really starting to dislike flags. I wish we'd just have optional arguments with default values and use booleans here.)
| are to be initialized, and a <var>legacy target override flag</var>, run these steps: | ||
|
|
||
| <ol> | ||
| <li><p>If <var>eventClass</var> is not given ,let <var>eventClass</var> be {{Event}}. |
| <var>e</var>, and its {{Event/isTrusted}} | ||
| attribute initialized to <code>true</code>, is to be | ||
| <a>dispatched</a> to the given object. | ||
| <p>To <dfn export id=concept-event-fire lt="fire an event">fire an event</dfn> named <var>e</var> at |
| attribute initialized to <code>true</code>, is to be | ||
| <a>dispatched</a> to the given object. | ||
| <p>To <dfn export id=concept-event-fire lt="fire an event">fire an event</dfn> named <var>e</var> at | ||
| <var>target</var>, optionally given an <var>eventClass</var>, a description of how IDL attributes |
There was a problem hiding this comment.
Maybe eventInterface is more accurate? I dunno, I want to use JS terms, but this is kind of Web IDL land. Could go either way.
There was a problem hiding this comment.
I guess we can go with interface for now. IDL should really rename things though...
|
|
||
| <li><p>Return the result of <a>dispatching</a> <var>event</var> at <var>target</var>, with | ||
| <var>legacy target override flag</var> set if set. | ||
| </ol> | ||
|
|
||
| <p class="note no-backref">Fire in the context of DOM is short for creating, initializing, |
There was a problem hiding this comment.
It might be worth adding a more complex example that uses eventClass and initializes some extra attributes, and possibly uses the return value.
|
|
||
| <li><p>Initialize <var>event</var>'s {{Event/type}} attribute to <var>e</var>. | ||
| <li><p>Let <var>event</var> be the result of <a for=Event lt=constructor>invoking</a> the initial | ||
| value of <var>eventConstructor</var> with <var>e</var> as argument. |
| {{Event/cancelable}} attribute initialized to true". | ||
|
|
||
| <p>Or, when a custom constructor is required, "<a>fire an event</a> named <code>click</code> at | ||
| <var>target</var> using <code>MouseEvent</code> with its {{Event/isTrusted}} attribute initialized |
There was a problem hiding this comment.
Use {{MouseEvent}} instead of <code>MouseEvent</code> to get some free auto-linking.
|
Will fix those and then land. |
|
Thanks for reviewing! |
Fixes #187. Follow up work in HTML is tracked in
whatwg/html#1713.