Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export the term "target override" #187

Closed
cvrebert opened this issue Mar 11, 2016 · 6 comments
Closed

Export the term "target override" #187

cvrebert opened this issue Mar 11, 2016 · 6 comments

Comments

@cvrebert
Copy link
Member

This term is currently relied upon by HTML: https://html.spec.whatwg.org/#concept-event-target-override

@annevk
Copy link
Member

annevk commented Mar 11, 2016

I think it would be better for HTML to invoke the dispatch algorithm correctly. I'm not sure we should be introducing named arguments (other than flags).

@cvrebert
Copy link
Member Author

That sounds fine too.

@annevk
Copy link
Member

annevk commented Mar 14, 2016

One problem DOM needs to fix here is that "fire an event" doesn't take a target and target override argument currently and HTML seems to use those anyway.

@cvrebert
Copy link
Member Author

Ah, the joys of untypechecked prose algorithms...

@annevk
Copy link
Member

annevk commented Oct 11, 2016

The other thing we need to fix is that "fire an event" needs to return whatever dispatch returns so HTML can use that instead of "default action" talk.

annevk added a commit that referenced this issue Oct 13, 2016
Fixes #187. Follow up work in HTML is tracked in
whatwg/html#1713.
annevk added a commit that referenced this issue Oct 14, 2016
Fixes #187. Follow up work in HTML is tracked in whatwg/html#1713.
@annevk
Copy link
Member

annevk commented Oct 14, 2016

Thanks for reporting this, HTML side is being worked on still, but should be good somewhere next week hopefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants