Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set createDocument() content type from namespace #218

Closed
wants to merge 1 commit into from

Conversation

ayg
Copy link
Contributor

@ayg ayg commented Apr 13, 2016

Fixes #217.

<dd><code>image/svg+xml</code>

<dt><a>MathML namespace</a>
<dd><code>application/mathml+xml</code>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per #217 (comment) it seems this should be application/xml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is MathML something we want to acknowledge in spec-land, or should we just ignore it as a failed experiment? I guess if no more UAs are realistically planning to implement it, we should probably ignore it, yeah.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought -- the HTML spec acknowledges SVG and MathML as things you can natively embed in HTML. Given that, I think we should special-case MathML as well. Alternatively, perhaps the tag should be removed from HTML, unless anyone is ever going to use it in real life. (I think Hixie added it on principle, not because there was significant implementer or author interest.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MathML is supported in Gecko but Gecko uses application/xml here. I don't see any particular reason to use something different here; the main difference is for createElement but that doesn't special-case application/mathml+xml anyway, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @zcorpan, FWIW.

@ayg ayg force-pushed the createDocument-contentType branch from 631d517 to df127c2 Compare April 17, 2016 12:44
@ayg
Copy link
Contributor Author

ayg commented Apr 17, 2016

Rewritten to address feedback.

@zcorpan
Copy link
Member

zcorpan commented Apr 17, 2016

LGTM

@ArkadiuszMichalski
Copy link
Contributor

ArkadiuszMichalski commented Apr 18, 2016

Are there any APIs which depend on image/svg+xml content type in Document? Or added due to Chromium/WebKit behavior?

@annevk
Copy link
Member

annevk commented Apr 18, 2016

I don't know of any APIs other than createElement() that use it so I guess it's the latter. Do you think it's problematic?

@zcorpan
Copy link
Member

zcorpan commented Apr 18, 2016

img accepts image/svg+xml but rejects application/xml when loading a resource. You can't assign a document to an img but maybe if we add srcObject it could become relevant.

@ArkadiuszMichalski
Copy link
Contributor

@annevk No, it's not problem, just asked to eventualy learning something new.

annevk pushed a commit that referenced this pull request Apr 18, 2016
@annevk
Copy link
Member

annevk commented Apr 18, 2016

Landed as 537e579. Thanks @ayg!

@annevk annevk closed this Apr 18, 2016
tabatkins added a commit to tabatkins/dom that referenced this pull request Apr 28, 2016
* Add more legacy event types for createEvent()

Approximately as requested at
https://bugzilla.mozilla.org/show_bug.cgi?id=1251198#c7. This is the
list of events supported in createEvent() by at least two of Firefox,
Chrome, and IE 11. The one exception is I omitted MutationEvent,
which all three support, because apparently spec-land has decided to
deny its existence in the hope that it will go away.

Bikeshed does not know about all of the added interface names,
hopefully that will sort itself out over time.

* Meta: improve pull request instructions for DOM

See whatwg/fetch#276 for context.

* Enable an event listener to be invoked just once

* Editorial: web compatibility typically remains relevant

Fixes whatwg#210.

* Shadow: define attachShadow() for custom elements

* Meta: make it easier to reference participate in a tree

PR: whatwg#216

* Define node document for new Text nodes

Fixes whatwg#224 and part of whatwg#212. Also fix part of whatwg#209 by stating these
algorithms can rethrow exceptions.

* Use a single concept for attribute changes

This setup is still a little sketchy I think, but not more so than the
insertion and removing steps.

* SVGEvent is only Gecko, Blink also has SVGEvents

As pointed out by zcorpan in whatwg#227.

* Set createDocument()'s content type based on namespace

Fixes whatwg#217.

PR: whatwg#218

* Make document.createEvent("touchevent") sometimes throw

Browsers typically disable touch events on non-touch devices, and there exists web content that detects this difference using document.createEvent().

Fixes whatwg#227.

* Shadow: define slotchange event

Shadow: define slotchange event

Fixes WICG/webcomponents#288.

This defines the slotchange event in response to remove/insert operations, changes to a slot’s name attribute, and changes to an element’s slot attribute.

This also introduces the assigned nodes concept for slots, and assigned slot concept for slotables.

Slotables now also have a name, rather than a “get name”.

The slotchange event dispatches just after mutation observers have their callbacks invoked. The slotchange event is not yet marked scoped as scoped events are not yet defined in the DOM Standard.

Note: although the original issue did not mention it, this also suppresses signaling when slots are removed from a tree. Not just when they are inserted.

* Editorial: update custom element cross-spec references

* Editorial: fix a few cross-linking missteps

* Editorial: make "is" and "prefix" optional in "create an element"

* Use "create an element" in createHTMLDocument

Takes care of part of whatwg#212.

* Editorial: align exception language with IDL

* Editorial: introduce more shadow-including terms for CSS

Fixes whatwg#225.

* Editorial: distributed -> flattened

* Meta: export more terms

Fixes whatwg#233.

* Editorial: add "shadow host" and "assigned" as terms

This makes a couple of non-null checks read better and enshrines a term
we had already been using.

* Editorial: flip non-null/otherwise conditions

PR: whatwg#234

* Shadow: <slot> is now defined in HTML

* Remove passive as event listener key

This changes makes passive no longer contribute to the uniqueness of
an event listener. It therefore also no longer needs to be supported
as part of removeEventListener().

Fixes WICG/EventListenerOptions#27.

PR: whatwg#236

* Meta: point out event's timeStamp is likely to change

See whatwg#23 for details.

* Add [CEReactions] annotations to mutating methods

Part of WICG/webcomponents#186, and furthering whatwg/html@27aa7bc.

Linking [CEREactions] will happen once speced/bikeshed#677 is fixed.

* Editorial: check stop propagation flag at start of invoke

* Editorial: deduplicate Veli Şenol

* Editorial: define defaults for EventListenerOptions

Although this is also done in prose, this nonetheless simplifies the
prose a bit and makes it clearer to those skimming the standard what is
going on (although skimming is not recommended).

Fixes whatwg#239.

* Meta: link to Japanese translation

See
triple-underscore/triple-underscore.github.io#1
for more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants