Inconsistency when using "Rethrow any exceptions" #209
Comments
|
The preference is to call it out since it's not always obvious what should be done to implementers. And sometimes we don't rethrow the exception, but report it instead (event dispatch for instance). Hopefully longer term we have some ECMAScript-inspired formalism in IDL we can use, but until that time this is what we got. |
tabatkins
added a commit
to tabatkins/dom
that referenced
this issue
Apr 28, 2016
* Add more legacy event types for createEvent() Approximately as requested at https://bugzilla.mozilla.org/show_bug.cgi?id=1251198#c7. This is the list of events supported in createEvent() by at least two of Firefox, Chrome, and IE 11. The one exception is I omitted MutationEvent, which all three support, because apparently spec-land has decided to deny its existence in the hope that it will go away. Bikeshed does not know about all of the added interface names, hopefully that will sort itself out over time. * Meta: improve pull request instructions for DOM See whatwg/fetch#276 for context. * Enable an event listener to be invoked just once * Editorial: web compatibility typically remains relevant Fixes whatwg#210. * Shadow: define attachShadow() for custom elements * Meta: make it easier to reference participate in a tree PR: whatwg#216 * Define node document for new Text nodes Fixes whatwg#224 and part of whatwg#212. Also fix part of whatwg#209 by stating these algorithms can rethrow exceptions. * Use a single concept for attribute changes This setup is still a little sketchy I think, but not more so than the insertion and removing steps. * SVGEvent is only Gecko, Blink also has SVGEvents As pointed out by zcorpan in whatwg#227. * Set createDocument()'s content type based on namespace Fixes whatwg#217. PR: whatwg#218 * Make document.createEvent("touchevent") sometimes throw Browsers typically disable touch events on non-touch devices, and there exists web content that detects this difference using document.createEvent(). Fixes whatwg#227. * Shadow: define slotchange event Shadow: define slotchange event Fixes WICG/webcomponents#288. This defines the slotchange event in response to remove/insert operations, changes to a slot’s name attribute, and changes to an element’s slot attribute. This also introduces the assigned nodes concept for slots, and assigned slot concept for slotables. Slotables now also have a name, rather than a “get name”. The slotchange event dispatches just after mutation observers have their callbacks invoked. The slotchange event is not yet marked scoped as scoped events are not yet defined in the DOM Standard. Note: although the original issue did not mention it, this also suppresses signaling when slots are removed from a tree. Not just when they are inserted. * Editorial: update custom element cross-spec references * Editorial: fix a few cross-linking missteps * Editorial: make "is" and "prefix" optional in "create an element" * Use "create an element" in createHTMLDocument Takes care of part of whatwg#212. * Editorial: align exception language with IDL * Editorial: introduce more shadow-including terms for CSS Fixes whatwg#225. * Editorial: distributed -> flattened * Meta: export more terms Fixes whatwg#233. * Editorial: add "shadow host" and "assigned" as terms This makes a couple of non-null checks read better and enshrines a term we had already been using. * Editorial: flip non-null/otherwise conditions PR: whatwg#234 * Shadow: <slot> is now defined in HTML * Remove passive as event listener key This changes makes passive no longer contribute to the uniqueness of an event listener. It therefore also no longer needs to be supported as part of removeEventListener(). Fixes WICG/EventListenerOptions#27. PR: whatwg#236 * Meta: point out event's timeStamp is likely to change See whatwg#23 for details. * Add [CEReactions] annotations to mutating methods Part of WICG/webcomponents#186, and furthering whatwg/html@27aa7bc. Linking [CEREactions] will happen once speced/bikeshed#677 is fixed. * Editorial: check stop propagation flag at start of invoke * Editorial: deduplicate Veli Şenol * Editorial: define defaults for EventListenerOptions Although this is also done in prose, this nonetheless simplifies the prose a bit and makes it clearer to those skimming the standard what is going on (although skimming is not recommended). Fixes whatwg#239. * Meta: link to Japanese translation See triple-underscore/triple-underscore.github.io#1 for more details.
annevk
added a commit
that referenced
this issue
Mar 16, 2017
|
I posted a PR to fix at least these. Review welcome. If you find more I'm happy to take PRs from you or new issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is convenction when we have nested algorithms and some of them throws exception, this exception should be always rethrows in the calling algorithm (and marking it in prose)? Now it's unclear, especially for node mutations.
Some analysis:
https://dom.spec.whatwg.org/#dom-element-insertadjacentelement
insertAdjacentElement(where, element)(rethrow for "insert-adjacent") > "insert-adjacent" (rethrow for "pre-insert") > "pre-insert" (not rethrow for "ensure pre-insertion validity") > "ensure pre-insertion validity" (throw)"
https://dom.spec.whatwg.org/#dom-node-appendchild
appendChild(node)(not rethrow for "append") > "append" (not rethrow for "pre-insert") > "pre-insert" (not rethrow for "ensure pre-insertion validity") > "ensure pre-insertion validity" (throw)https://dom.spec.whatwg.org/#dom-node-replacechild
replaceChild(node, child)(not rethrow for "replace") > "replace" (throw)Only three examples, but there are more, not olny for nodes, at once hard to locate all of them.
The text was updated successfully, but these errors were encountered: