Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crud admin screens named references #421

Merged
merged 39 commits into from
Jul 25, 2023
Merged

Crud admin screens named references #421

merged 39 commits into from
Jul 25, 2023

Conversation

manuel-delvillar
Copy link
Contributor

@manuel-delvillar manuel-delvillar commented Jun 20, 2023 •
edited
Loading

Create Metadata Button

Button to Create

Screenshot 2023-07-17 at 14 14 57

Create Keyword Form

Screenshot 2023-07-17 at 14 15 26 Screenshot 2023-07-17 at 14 15 48

Manage Named Reference

Screenshot 2023-07-17 at 14 15 59

Edit Form

Screenshot 2023-07-17 at 14 16 08

@manuel-delvillar manuel-delvillar force-pushed the feature/OSMT-283-detail-crud-admin-screens branch 2 times, most recently from 477ae64 to 96d9751 Compare June 20, 2023 18:37
@manuel-delvillar manuel-delvillar force-pushed the feature/OSMT-283-detail-crud-admin-screens branch from 96d9751 to 08c6071 Compare June 28, 2023 18:20
@manuel-delvillar manuel-delvillar force-pushed the feature/admin-screens branch 3 times, most recently from ab69586 to 2fec338 Compare July 11, 2023 20:17
@manuel-delvillar manuel-delvillar force-pushed the feature/OSMT-283-detail-crud-admin-screens branch 2 times, most recently from 87ff868 to 558a0df Compare July 12, 2023 18:41
@Corpratespaz Corpratespaz mentioned this pull request Jul 14, 2023
Draft
8 tasks
@manuel-delvillar manuel-delvillar force-pushed the feature/OSMT-283-detail-crud-admin-screens branch from 558a0df to 089a256 Compare July 17, 2023 18:55
@manuel-delvillar manuel-delvillar changed the title Feature/osmt 283 detail crud admin screens Crud admin screens Jul 18, 2023
@manuel-delvillar manuel-delvillar force-pushed the feature/admin-screens branch 2 times, most recently from 7d8e4cf to ba02a07 Compare July 19, 2023 17:01
@manuel-delvillar manuel-delvillar force-pushed the feature/OSMT-283-detail-crud-admin-screens branch from 089a256 to cc74976 Compare July 19, 2023 17:14
@manuel-delvillar manuel-delvillar changed the title Crud admin screens Crud admin screens named references Jul 19, 2023
@manuel-delvillar manuel-delvillar force-pushed the feature/OSMT-283-detail-crud-admin-screens branch from cc74976 to a5a1717 Compare July 19, 2023 17:16
jchavez137
jchavez137 reviewed Jul 19, 2023
View reviewed changes
@manuel-delvillar manuel-delvillar marked this pull request as ready for review July 20, 2023 21:47
@manuel-delvillar manuel-delvillar requested a review from a team July 20, 2023 21:48
@manuel-delvillar manuel-delvillar self-assigned this Jul 20, 2023
@manuel-delvillar manuel-delvillar added the enhancement New feature or request label Jul 20, 2023
@manuel-delvillar manuel-delvillar force-pushed the feature/OSMT-283-detail-crud-admin-screens branch from 82d38b2 to 73a3f19 Compare July 20, 2023 21:51
Corpratespaz and others added 7 commits July 21, 2023 10:34
@Corpratespaz @manuel-delvillar
Refactor of Category dertail view for metadata
28b1877
@Corpratespaz @manuel-delvillar
OSMT-279: Fixed rebase issue with service & names
3d735c2
@jchavez137 @manuel-delvillar
Fix after rebase onto feature/admin-screens
53a2681 
Search/Filter/Delete Metadata Keywords(Named References) Enabling (#426)

* Refactoring Controller to accept keyword type

* Renaming Keyword RoutePaths

* Addind overloaded typeAheadSearch method with pageable

* Working on UI, adding service endpoint calls, adding service to NR table components.

* Converting delete process to be task result, adjusting labels for plural category

* removing unused named reference service, fixing enum issue, fixing case insensitive sort..

* adding unit tests

* Removing unused code for category screens, updating API yaml file

* Removing hardcoded totalPageCount for named reference table, removing unused imports.

* Reverting skillCount field back, fixing some PR comments, updating openapi.yaml

* Removing unused imports.

* Removing unused imports.

* Refactoring deletion logic, fixing mock data.

* Removing comented out line

* Removing unused RoutePath

* Add postman tests for job codes

* Adding test coverage scripts

* Adding test coverage scripts

* Adding test coverage scripts

* Correcting scripts.

* Removing category script tests, No more needed.

* Fix job code tests

* Add pre request in id folder

* Fix get pagination

- Remove query parameter

* Updating update keyword test.

---------

Co-authored-by: manuel-delvillar <[email protected]>

OSMT- 276 service classes UI (#391)

* Adding new services classes for jobCodes and namedReferences

* Renaming package and services name classes. Extending new abstract class from the existing one.

* refactoring JobCode classes and package. Adding CRUD requests

* adding providers for unit testing in abstract-data.service.spec.ts

* Adding Enum for MetadataType, Optimizing Imports

* Adding implementation for delete method in Abstract service

* Remove unused code

- Remove ApiGetParams.

- Constructor in abstract.service now is protected.

* Add alias for test directory

* Adding new services classes for jobCodes and namedReferences

* Renaming package and services name classes. Extending new abstract class from the existing one

* updating openapi.yaml to match endpoint definition

* Correcting Routepath and refactoring web methods

* Correcting buildTableParams sort param

* Updating endpoints call to match definition

---------

Co-authored-by: manuel-delvillar <[email protected]>

Adding Screen to Search/Filter Metadata (#401)

* Adding new services classes for jobCodes and namedReferences

* Renaming package and services name classes. Extending new abstract class from the existing one.

* refactoring JobCode classes and package. Adding CRUD requests

* Adding Enum for MetadataType, Optimizing Imports

* Adding implementation for delete method in Abstract service

* Adding new services classes for jobCodes and namedReferences

* Renaming package and services name classes. Extending new abstract class from the existing one.

* refactoring JobCode classes and package. Adding CRUD requests

* Adding Enum for MetadataType, Optimizing Imports

* updating openapi.yaml to match endpoint definition.

* Correcting Routepath and refactoring web methods

* Refactoring entry points in navigation bar
@manuel-delvillar
Remove metadata folder
89b0ffc 
- Metadata already exists on v3.
@manuel-delvillar
Remove duplicated service
1341861
@Corpratespaz @manuel-delvillar
OSMT-279: Readd Form view and fix service
506b285
@jchavez137 @manuel-delvillar
Adding Screen to Search/Filter Metadata (#401)
e505a7c 
* Adding new services classes for jobCodes and namedReferences

* Renaming package and services name classes. Extending new abstract class from the existing one.

* refactoring JobCode classes and package. Adding CRUD requests

* Adding Enum for MetadataType, Optimizing Imports

* Adding implementation for delete method in Abstract service

* Adding new services classes for jobCodes and namedReferences

* Renaming package and services name classes. Extending new abstract class from the existing one.

* refactoring JobCode classes and package. Adding CRUD requests

* Adding Enum for MetadataType, Optimizing Imports

* updating openapi.yaml to match endpoint definition.

* Correcting Routepath and refactoring web methods

* Refactoring entry points in navigation bar
@manuel-delvillar
Edit metadata
846e376
@manuel-delvillar
Improve create
d750f61
@manuel-delvillar
Delete named reference
6fa3ad6 
- Create new task

- Update back end for new task
@manuel-delvillar
Improve create button
0db114d 
- Improve create metadata position and size in ui.
@manuel-delvillar
Show name of edited metadata
a63939a
@manuel-delvillar
Load related skills
ad17638
@manuel-delvillar
Search related skills
4bc6f32
@manuel-delvillar
Load information in public view
374de29
@manuel-delvillar
Fix broken ui tests
3178a37
@manuel-delvillar
Update API tests
102ab86 
- Add test to KeywordController.

- Update open api v3.

- Add test for open api v3.
@manuel-delvillar
Rename folder & add tests
29d1bbc 
- Rename folder of create-named-reference.component.html

- Add test for create-named-reference.component.spec.ts
@manuel-delvillar
Reindex related RSDs after update keyword
9e5fed1
@manuel-delvillar
Fix comments in PR
5aeb79f 
- Use RemoveItemTask instead of new RemoveKeyword.

- Rename searchCategorySkills to searchKeywordSkills.

- Remove white lines.
@manuel-delvillar
Add test search related skills with query
970ed51
@manuel-delvillar
Remove unused lines
b18880c
@manuel-delvillar
Add test create-named-reference
c8e2088
@manuel-delvillar
Fix api after rebase on feature/admin-screens
89fb532
@manuel-delvillar manuel-delvillar force-pushed the feature/OSMT-283-detail-crud-admin-screens branch from 77d52cd to ff00b89 Compare July 21, 2023 17:26
@manuel-delvillar manuel-delvillar force-pushed the feature/OSMT-283-detail-crud-admin-screens branch from ff00b89 to e9bb39d Compare July 21, 2023 17:29
Corpratespaz
Corpratespaz suggested changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@Corpratespaz Corpratespaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I've made a couple of naming/documentation requests and a few display text alteration requests for improving user experience.

@Corpratespaz Corpratespaz merged commit 63926d9 into feature/admin-screens Jul 25, 2023
@Corpratespaz Corpratespaz deleted the feature/OSMT-283-detail-crud-admin-screens branch July 25, 2023 14:28
Corpratespaz pushed a commit that referenced this pull request Jul 25, 2023
@manuel-delvillar @Corpratespaz
Crud admin screens named references (#421)
6c240d5 
* Add create named reference

* Edit metadata

* Improve create button

- Improve create metadata position and size in ui.

* Show name of edited metadata

* Load related skills

* Search related skills

* Load information in public view

* Fix broken ui tests

* Update API tests

- Add test to KeywordController.

- Update open api v3.

* Reindex related RSDs after update keyword

* Add test create-named-reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchavez137 jchavez137 jchavez137 left review comments

@Corpratespaz Corpratespaz Corpratespaz approved these changes

Assignees

@manuel-delvillar manuel-delvillar

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manuel-delvillar @Corpratespaz @jchavez137