-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Screen to Search/Filter Metadata #401
Merged
Corpratespaz
merged 42 commits into
feature/admin-screens
from
feature/OSMT-278-admin-search-screen
May 24, 2023
Merged
Adding Screen to Search/Filter Metadata #401
Corpratespaz
merged 42 commits into
feature/admin-screens
from
feature/OSMT-278-admin-search-screen
May 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jchavez137
commented
May 18, 2023
•
edited
Loading
edited
- Created New entry point for Search/Filter Metadata
- Reorganized entry points for within a Menu
- Created table components to display results for Metadata search/Filter
- Added sample result display for static search
10cbdbd
to
c3d5843
Compare
…ass from the existing one.
…ass from the existing one.
c3d5843
to
526c979
Compare
Corpratespaz
pushed a commit
that referenced
this pull request
May 31, 2023
* Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jun 13, 2023
* Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jun 13, 2023
* Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jun 28, 2023
* Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
8 tasks
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 7, 2023
* Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
Corpratespaz
pushed a commit
that referenced
this pull request
Jul 12, 2023
* Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 12, 2023
* Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 12, 2023
* Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 12, 2023
* Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 12, 2023
Search/Filter/Delete Metadata Keywords(Named References) Enabling (#426) * Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <[email protected]> OSMT- 276 service classes UI (#391) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * adding providers for unit testing in abstract-data.service.spec.ts * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Remove unused code - Remove ApiGetParams. - Constructor in abstract.service now is protected. * Add alias for test directory * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one * updating openapi.yaml to match endpoint definition * Correcting Routepath and refactoring web methods * Correcting buildTableParams sort param * Updating endpoints call to match definition --------- Co-authored-by: manuel-delvillar <[email protected]> Adding Screen to Search/Filter Metadata (#401) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 12, 2023
* Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 14, 2023
Search/Filter/Delete Metadata Keywords(Named References) Enabling (#426) * Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <[email protected]> OSMT- 276 service classes UI (#391) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * adding providers for unit testing in abstract-data.service.spec.ts * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Remove unused code - Remove ApiGetParams. - Constructor in abstract.service now is protected. * Add alias for test directory * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one * updating openapi.yaml to match endpoint definition * Correcting Routepath and refactoring web methods * Correcting buildTableParams sort param * Updating endpoints call to match definition --------- Co-authored-by: manuel-delvillar <[email protected]> Adding Screen to Search/Filter Metadata (#401) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 17, 2023
* Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 18, 2023
* Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 19, 2023
* Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 19, 2023
Search/Filter/Delete Metadata Keywords(Named References) Enabling (#426) * Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <[email protected]> OSMT- 276 service classes UI (#391) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * adding providers for unit testing in abstract-data.service.spec.ts * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Remove unused code - Remove ApiGetParams. - Constructor in abstract.service now is protected. * Add alias for test directory * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one * updating openapi.yaml to match endpoint definition * Correcting Routepath and refactoring web methods * Correcting buildTableParams sort param * Updating endpoints call to match definition --------- Co-authored-by: manuel-delvillar <[email protected]> Adding Screen to Search/Filter Metadata (#401) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 19, 2023
* Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 19, 2023
Search/Filter/Delete Metadata Keywords(Named References) Enabling (#426) * Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <[email protected]> OSMT- 276 service classes UI (#391) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * adding providers for unit testing in abstract-data.service.spec.ts * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Remove unused code - Remove ApiGetParams. - Constructor in abstract.service now is protected. * Add alias for test directory * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one * updating openapi.yaml to match endpoint definition * Correcting Routepath and refactoring web methods * Correcting buildTableParams sort param * Updating endpoints call to match definition --------- Co-authored-by: manuel-delvillar <[email protected]> Adding Screen to Search/Filter Metadata (#401) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 19, 2023
* Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
jchavez137
added a commit
that referenced
this pull request
Jul 19, 2023
* Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 20, 2023
Search/Filter/Delete Metadata Keywords(Named References) Enabling (#426) * Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <[email protected]> OSMT- 276 service classes UI (#391) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * adding providers for unit testing in abstract-data.service.spec.ts * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Remove unused code - Remove ApiGetParams. - Constructor in abstract.service now is protected. * Add alias for test directory * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one * updating openapi.yaml to match endpoint definition * Correcting Routepath and refactoring web methods * Correcting buildTableParams sort param * Updating endpoints call to match definition --------- Co-authored-by: manuel-delvillar <[email protected]> Adding Screen to Search/Filter Metadata (#401) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 20, 2023
* Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
Corpratespaz
pushed a commit
that referenced
this pull request
Jul 21, 2023
Search/Filter/Delete Metadata Keywords(Named References) Enabling (#426) * Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <[email protected]> OSMT- 276 service classes UI (#391) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * adding providers for unit testing in abstract-data.service.spec.ts * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Remove unused code - Remove ApiGetParams. - Constructor in abstract.service now is protected. * Add alias for test directory * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one * updating openapi.yaml to match endpoint definition * Correcting Routepath and refactoring web methods * Correcting buildTableParams sort param * Updating endpoints call to match definition --------- Co-authored-by: manuel-delvillar <[email protected]> Adding Screen to Search/Filter Metadata (#401) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 21, 2023
Search/Filter/Delete Metadata Keywords(Named References) Enabling (#426) * Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <[email protected]> OSMT- 276 service classes UI (#391) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * adding providers for unit testing in abstract-data.service.spec.ts * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Remove unused code - Remove ApiGetParams. - Constructor in abstract.service now is protected. * Add alias for test directory * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one * updating openapi.yaml to match endpoint definition * Correcting Routepath and refactoring web methods * Correcting buildTableParams sort param * Updating endpoints call to match definition --------- Co-authored-by: manuel-delvillar <[email protected]> Adding Screen to Search/Filter Metadata (#401) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 21, 2023
* Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
Corpratespaz
pushed a commit
that referenced
this pull request
Jul 25, 2023
* Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.