-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(CSI-305): change mount Map logic for WEKAFS to align with NFS and support same fs name on SCMC #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sergeyberezansky and the rest of your teammates on Graphite |
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (10/31/24)1 reviewer was added to this PR based on Sergey Berezansky's automation. |
sergeyberezansky
force-pushed
the
sergey/add-cluster-guid-to-mount-map
branch
from
November 1, 2024 10:04
425fc60
to
97718af
Compare
This was referenced Nov 1, 2024
sergeyberezansky
force-pushed
the
sergey/add-cluster-guid-to-mount-map
branch
4 times, most recently
from
November 3, 2024 17:43
084c3ea
to
8839d71
Compare
sergeyberezansky
changed the base branch from
sergey/multi-arch
to
graphite-base/383
November 7, 2024 10:18
…S and support same fs name on SCMC
…d multiple API calls
…unt during umount
sergeyberezansky
force-pushed
the
sergey/add-cluster-guid-to-mount-map
branch
from
November 7, 2024 10:18
8839d71
to
8f386ec
Compare
sergeyberezansky
force-pushed
the
sergey/add-cluster-guid-to-mount-map
branch
from
November 7, 2024 10:19
8f386ec
to
dbdd772
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Refactored mount handling to improve container name management and mount reference counting.
What changed?
EnsureLocalContainer
method to handle container name resolutionHow to test?
Why make this change?