Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CSI-303): add livenessProbe to attacher sidecar #382

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

sergeyberezansky
Copy link
Collaborator

@sergeyberezansky sergeyberezansky commented Oct 29, 2024

TL;DR

Added support for attacher metrics and leader election configuration in the CSI WekaFS plugin.

What changed?

  • Added configureAttacherLeaderElection option in the controller section of values.yaml
  • Included attacher metrics port (default 9095) in the Prometheus annotations
  • Updated the csi-attacher container configuration in the controller deployment:
    • Added conditional leader election flags
    • Added HTTP endpoint for metrics
    • Included liveness probe for leader election health check
  • Added attacherPort (default 9095) to the metrics section in values.yaml

How to test?

  1. Deploy the chart with controller.configureAttacherLeaderElection set to true
  2. Verify that the attacher container in the controller deployment has the leader election flags and liveness probe
  3. Check if the Prometheus annotations include the attacher metrics port
  4. Access the attacher metrics endpoint at http://<pod-ip>:9095/metrics

Why make this change?

This change enhances the CSI WekaFS plugin by:

  1. Allowing users to configure leader election for the attacher sidecar, improving high availability and fault tolerance
  2. Exposing attacher metrics, enabling better monitoring and observability of the CSI plugin's performance
  3. Providing a health check endpoint for the attacher's leader election, ensuring proper functioning in distributed environments

@graphite-app graphite-app bot requested a review from tigrawap October 29, 2024 19:01
Copy link

graphite-app bot commented Oct 29, 2024

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (10/29/24)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

@sergeyberezansky sergeyberezansky force-pushed the sergey/convert-controller-to-deployment branch from c0b5f41 to df2ec47 Compare October 29, 2024 19:19
@sergeyberezansky sergeyberezansky force-pushed the sergey/add-attacher-liveness-probe branch 2 times, most recently from 3414d29 to 481b10f Compare October 29, 2024 20:40
@sergeyberezansky sergeyberezansky added the enhancement New feature or request label Oct 29, 2024
@sergeyberezansky sergeyberezansky force-pushed the sergey/convert-controller-to-deployment branch from df2ec47 to 7a06d00 Compare October 29, 2024 22:12
@sergeyberezansky sergeyberezansky force-pushed the sergey/add-attacher-liveness-probe branch from 481b10f to feda68b Compare October 29, 2024 22:13
@sergeyberezansky sergeyberezansky force-pushed the sergey/convert-controller-to-deployment branch from 7a06d00 to b95c4c6 Compare October 29, 2024 22:22
@sergeyberezansky sergeyberezansky force-pushed the sergey/add-attacher-liveness-probe branch 2 times, most recently from d6a2048 to 446404b Compare October 29, 2024 22:30
Copy link
Collaborator Author

sergeyberezansky commented Oct 30, 2024

Merge activity

  • Oct 30, 3:26 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 30, 3:27 AM EDT: Graphite couldn't merge this pull request because a downstack PR feat(CSI-301): bump locar to version 0.4.2 #380 failed to merge.
  • Oct 30, 5:19 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 30, 5:42 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 30, 5:45 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 30, 6:05 AM EDT: A user merged this pull request with Graphite.

@sergeyberezansky sergeyberezansky force-pushed the sergey/convert-controller-to-deployment branch 2 times, most recently from fc53262 to 94d2935 Compare October 30, 2024 07:39
@sergeyberezansky sergeyberezansky force-pushed the sergey/add-attacher-liveness-probe branch from 446404b to b690508 Compare October 30, 2024 07:39
@sergeyberezansky sergeyberezansky changed the base branch from sergey/convert-controller-to-deployment to graphite-base/382 October 30, 2024 09:19
@sergeyberezansky sergeyberezansky changed the base branch from graphite-base/382 to dev October 30, 2024 09:40
@sergeyberezansky sergeyberezansky force-pushed the sergey/add-attacher-liveness-probe branch from b690508 to b544a22 Compare October 30, 2024 09:41
@sergeyberezansky sergeyberezansky force-pushed the sergey/add-attacher-liveness-probe branch from b544a22 to 7768260 Compare October 30, 2024 09:44
@sergeyberezansky sergeyberezansky merged commit bddf9ed into dev Oct 30, 2024
12 checks passed
@sergeyberezansky sergeyberezansky deleted the sergey/add-attacher-liveness-probe branch November 28, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant