-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CSI-303): add livenessProbe to attacher sidecar #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sergeyberezansky and the rest of your teammates on Graphite |
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (10/29/24)1 reviewer was added to this PR based on Sergey Berezansky's automation. |
This was referenced Oct 29, 2024
sergeyberezansky
force-pushed
the
sergey/convert-controller-to-deployment
branch
from
October 29, 2024 19:19
c0b5f41
to
df2ec47
Compare
sergeyberezansky
force-pushed
the
sergey/add-attacher-liveness-probe
branch
2 times, most recently
from
October 29, 2024 20:40
3414d29
to
481b10f
Compare
sergeyberezansky
force-pushed
the
sergey/convert-controller-to-deployment
branch
from
October 29, 2024 22:12
df2ec47
to
7a06d00
Compare
sergeyberezansky
force-pushed
the
sergey/add-attacher-liveness-probe
branch
from
October 29, 2024 22:13
481b10f
to
feda68b
Compare
sergeyberezansky
force-pushed
the
sergey/convert-controller-to-deployment
branch
from
October 29, 2024 22:22
7a06d00
to
b95c4c6
Compare
sergeyberezansky
force-pushed
the
sergey/add-attacher-liveness-probe
branch
2 times, most recently
from
October 29, 2024 22:30
d6a2048
to
446404b
Compare
Merge activity
|
sergeyberezansky
force-pushed
the
sergey/convert-controller-to-deployment
branch
2 times, most recently
from
October 30, 2024 07:39
fc53262
to
94d2935
Compare
sergeyberezansky
force-pushed
the
sergey/add-attacher-liveness-probe
branch
from
October 30, 2024 07:39
446404b
to
b690508
Compare
sergeyberezansky
changed the base branch from
sergey/convert-controller-to-deployment
to
graphite-base/382
October 30, 2024 09:19
sergeyberezansky
force-pushed
the
sergey/add-attacher-liveness-probe
branch
from
October 30, 2024 09:41
b690508
to
b544a22
Compare
sergeyberezansky
force-pushed
the
sergey/add-attacher-liveness-probe
branch
from
October 30, 2024 09:44
b544a22
to
7768260
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added support for attacher metrics and leader election configuration in the CSI WekaFS plugin.
What changed?
configureAttacherLeaderElection
option in the controller section ofvalues.yaml
attacherPort
(default 9095) to the metrics section invalues.yaml
How to test?
controller.configureAttacherLeaderElection
set to truehttp://<pod-ip>:9095/metrics
Why make this change?
This change enhances the CSI WekaFS plugin by: