fix(CSI-269): nfsmount mountPoint may be incorrect in certain cases

[sergeyberezansky]

TL;DR

Improved NFS mount handling, error reporting, and refcount management.

What changed?

• Enhanced NFS mount logging and error handling
• Improved refcount management for NFS mounts
• Updated ControllerExpandVolume to return NotFound instead of Internal error
• Removed unused locateMountIP method from interfaces
• Added retry mechanism for NFS mounts
• Implemented mount point removal after successful unmount
• Refactored LogActiveMounts and gcInactiveMounts methods

How to test?

1. Test NFS mount operations with various scenarios (successful mounts, failed mounts, retries)
2. Verify correct refcount management by mounting and unmounting volumes multiple times
3. Test ControllerExpandVolume with non-existent volumes
4. Verify mount point removal after unmounting
5. Check logs for improved error reporting and mount status information

Why make this change?

These changes aim to improve the reliability and robustness of NFS mount operations, provide better error handling and reporting, and enhance the overall stability of the CSI driver. The refactored refcount management and mount tracking should lead to more accurate resource management and prevent potential issues with stale mounts.

[sergeyberezansky]

• ci(CSI-213): add NFS sanity #340
• fix(CSI-269): nfsmount mountPoint may be incorrect in certain cases #345 👈
• fix(CSI-270): filesystem-backed volumes cannot be deleted due to stale NFS permissions #344
• feat(CSI-268): support NFS target IPs override via API secret #343
• fix(CSI-260): lookup of NFS interface group fails when empty name provided #341
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sergeyberezansky and the rest of your teammates on Graphite

[graphite-app]

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (09/27/24)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

[sergeyberezansky]

Merge activity

• Sep 27, 8:57 AM EDT: @sergeyberezansky started a stack merge that includes this pull request via Graphite.
• Sep 27, 9:16 AM EDT: Graphite rebased this pull request as part of a merge.
• Sep 27, 9:17 AM EDT: Graphite rebased this pull request as part of a merge.
• Sep 27, 9:23 AM EDT: @sergeyberezansky merged this pull request with Graphite.