-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(CSI-213): add NFS sanity #340
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sergeyberezansky and the rest of your teammates on Graphite |
sergeyberezansky
force-pushed
the
sergey/add-nfs-sanity
branch
from
September 23, 2024 09:14
5614a9a
to
61e0109
Compare
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (09/23/24)1 reviewer was added to this PR based on Sergey Berezansky's automation. |
sergeyberezansky
force-pushed
the
sergey/add-nfs-sanity
branch
2 times, most recently
from
September 23, 2024 09:56
f01dc33
to
16ce7ed
Compare
sergeyberezansky
changed the base branch from
dev
to
sergey/fix-empty-ig-fails-lookup
September 23, 2024 09:56
sergeyberezansky
force-pushed
the
sergey/fix-empty-ig-fails-lookup
branch
from
September 23, 2024 10:03
a3b70be
to
968dd78
Compare
sergeyberezansky
force-pushed
the
sergey/add-nfs-sanity
branch
2 times, most recently
from
September 23, 2024 10:10
2be5731
to
2773b0d
Compare
sergeyberezansky
force-pushed
the
sergey/fix-empty-ig-fails-lookup
branch
from
September 24, 2024 12:40
968dd78
to
bf7ba82
Compare
sergeyberezansky
force-pushed
the
sergey/add-nfs-sanity
branch
2 times, most recently
from
September 24, 2024 14:28
1461745
to
b8ce6f3
Compare
sergeyberezansky
force-pushed
the
sergey/fix-empty-ig-fails-lookup
branch
from
September 24, 2024 14:49
bf7ba82
to
4ea959e
Compare
sergeyberezansky
force-pushed
the
sergey/add-nfs-sanity
branch
2 times, most recently
from
September 24, 2024 14:56
41ecb2e
to
265d9ab
Compare
sergeyberezansky
force-pushed
the
sergey/fix-empty-ig-fails-lookup
branch
from
September 24, 2024 14:58
4ea959e
to
d7e0d5b
Compare
sergeyberezansky
force-pushed
the
sergey/add-nfs-sanity
branch
from
September 24, 2024 14:58
265d9ab
to
902c321
Compare
sergeyberezansky
force-pushed
the
sergey/fix-empty-ig-fails-lookup
branch
from
September 24, 2024 15:59
d7e0d5b
to
fe238e2
Compare
sergeyberezansky
force-pushed
the
sergey/add-nfs-sanity
branch
3 times, most recently
from
September 24, 2024 19:44
9ee804e
to
09188ba
Compare
sergeyberezansky
changed the base branch from
sergey/fix-empty-ig-fails-lookup
to
sergey/override-nfs-target-ips
September 24, 2024 19:44
sergeyberezansky
force-pushed
the
sergey/add-nfs-sanity
branch
5 times, most recently
from
September 25, 2024 14:13
1dba1b5
to
e2a4396
Compare
sergeyberezansky
force-pushed
the
sergey/add-nfs-sanity
branch
6 times, most recently
from
September 26, 2024 15:24
5d14963
to
d7d36d6
Compare
sergeyberezansky
force-pushed
the
sergey/add-nfs-sanity
branch
2 times, most recently
from
September 27, 2024 10:05
fcc9275
to
8fbcee7
Compare
sergeyberezansky
changed the base branch from
sergey/override-nfs-target-ips
to
sergey/delete-nfs-perms-on-fs-delete
September 27, 2024 10:05
sergeyberezansky
added
the
ci
Changes to CI/CD and release workflows
label
Sep 27, 2024
— with
Graphite App
sergeyberezansky
force-pushed
the
sergey/delete-nfs-perms-on-fs-delete
branch
from
September 27, 2024 10:30
62384c3
to
c0ad603
Compare
sergeyberezansky
force-pushed
the
sergey/add-nfs-sanity
branch
from
September 27, 2024 10:31
8fbcee7
to
31d27f5
Compare
sergeyberezansky
changed the base branch from
sergey/delete-nfs-perms-on-fs-delete
to
sergey/refcount-logic-fix-nfs
September 27, 2024 10:31
sergeyberezansky
force-pushed
the
sergey/add-nfs-sanity
branch
from
September 27, 2024 11:29
31d27f5
to
a878408
Compare
sergeyberezansky
force-pushed
the
sergey/refcount-logic-fix-nfs
branch
from
September 27, 2024 11:51
d052835
to
17b3135
Compare
sergeyberezansky
force-pushed
the
sergey/add-nfs-sanity
branch
from
September 27, 2024 11:51
a878408
to
b2039e3
Compare
sergeyberezansky
force-pushed
the
sergey/refcount-logic-fix-nfs
branch
from
September 27, 2024 12:27
17b3135
to
7358d79
Compare
sergeyberezansky
force-pushed
the
sergey/add-nfs-sanity
branch
from
September 27, 2024 12:27
b2039e3
to
33934b4
Compare
Merge activity
|
sergeyberezansky
changed the base branch from
sergey/refcount-logic-fix-nfs
to
graphite-base/340
September 27, 2024 13:15
sergeyberezansky
force-pushed
the
sergey/add-nfs-sanity
branch
from
September 27, 2024 13:24
33934b4
to
eedd7e7
Compare
sergeyberezansky
force-pushed
the
sergey/add-nfs-sanity
branch
from
September 27, 2024 13:26
eedd7e7
to
63d68e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added NFS support to CSI sanity tests and improved secret handling in GitHub Actions workflow.
What changed?
directory_volume_and_snapshots_nfs
to the GitHub Actions workflowdocker-compose-nfs-snapshotcaps.yaml
for NFS-specific testsdirectory_volume_and_snapshots_nfs()
to the sanity test scriptHow to test?
directory_volume_and_snapshots_nfs
job completes successfullyWhy make this change?
This change introduces NFS support to the CSI sanity tests, allowing for more comprehensive testing of the CSI driver's functionality.