-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CSI-236): for OCP installations, only 1 machineConfigPolicy was created #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 30, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sergeyberezansky and the rest of your teammates on Graphite |
This was referenced Jul 30, 2024
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (07/30/24)1 reviewer was added to this PR based on Sergey Berezansky's automation. |
sergeyberezansky
force-pushed
the
sergey/fix-wekafs-mount-leak
branch
from
July 30, 2024 12:19
b3a4bd7
to
638bb5f
Compare
This was referenced Jul 30, 2024
sergeyberezansky
force-pushed
the
sergey/ocp-machineconfig-fix
branch
from
July 31, 2024 05:32
1aaf7c0
to
fc00720
Compare
sergeyberezansky
changed the base branch from
sergey/fix-wekafs-mount-leak
to
sergey/fix-race-on-multi-delete
July 31, 2024 05:32
sergeyberezansky
force-pushed
the
sergey/fix-race-on-multi-delete
branch
from
July 31, 2024 08:34
b93a9d9
to
92205c0
Compare
sergeyberezansky
force-pushed
the
sergey/ocp-machineconfig-fix
branch
2 times, most recently
from
July 31, 2024 08:44
f6e7b38
to
0298f22
Compare
sergeyberezansky
force-pushed
the
sergey/fix-race-on-multi-delete
branch
from
July 31, 2024 10:09
1093ef5
to
64afcb5
Compare
sergeyberezansky
force-pushed
the
sergey/ocp-machineconfig-fix
branch
from
July 31, 2024 10:10
0298f22
to
1d56a95
Compare
sergeyberezansky
force-pushed
the
sergey/fix-race-on-multi-delete
branch
from
July 31, 2024 10:17
64afcb5
to
9763acf
Compare
sergeyberezansky
force-pushed
the
sergey/ocp-machineconfig-fix
branch
from
July 31, 2024 10:20
1d56a95
to
852b0e7
Compare
sergeyberezansky
changed the base branch from
sergey/fix-race-on-multi-delete
to
dev
July 31, 2024 10:21
Merge activity
|
sergeyberezansky
force-pushed
the
sergey/ocp-machineconfig-fix
branch
from
July 31, 2024 10:27
852b0e7
to
9aa68ca
Compare
sergeyberezansky
added
bug
Something isn't working
fix
and removed
bug
Something isn't working
labels
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixed missing divider between YAML documents when created in loop, causing only last document to be applied.
What changed?
Added the missing separator
How to test?
ONLY on OpenShift cluster:
Ensure that when multiple machineConfigLabels are specified in values.yaml, a
50-csi-wekafs-selinux-policy-{label}
is created for each label