Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CSI-236): for OCP installations, only 1 machineConfigPolicy was created #294

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

sergeyberezansky
Copy link
Collaborator

@sergeyberezansky sergeyberezansky commented Jul 30, 2024

TL;DR

Fixed missing divider between YAML documents when created in loop, causing only last document to be applied.

What changed?

Added the missing separator

How to test?

ONLY on OpenShift cluster:
Ensure that when multiple machineConfigLabels are specified in values.yaml, a 50-csi-wekafs-selinux-policy-{label} is created for each label

Copy link

graphite-app bot commented Jul 30, 2024

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (07/30/24)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

@sergeyberezansky sergeyberezansky force-pushed the sergey/fix-wekafs-mount-leak branch from b3a4bd7 to 638bb5f Compare July 30, 2024 12:19
@sergeyberezansky sergeyberezansky force-pushed the sergey/ocp-machineconfig-fix branch from 1aaf7c0 to fc00720 Compare July 31, 2024 05:32
@sergeyberezansky sergeyberezansky changed the base branch from sergey/fix-wekafs-mount-leak to sergey/fix-race-on-multi-delete July 31, 2024 05:32
@sergeyberezansky sergeyberezansky force-pushed the sergey/fix-race-on-multi-delete branch from b93a9d9 to 92205c0 Compare July 31, 2024 08:34
@sergeyberezansky sergeyberezansky force-pushed the sergey/ocp-machineconfig-fix branch 2 times, most recently from f6e7b38 to 0298f22 Compare July 31, 2024 08:44
@sergeyberezansky sergeyberezansky force-pushed the sergey/fix-race-on-multi-delete branch from 1093ef5 to 64afcb5 Compare July 31, 2024 10:09
@sergeyberezansky sergeyberezansky force-pushed the sergey/ocp-machineconfig-fix branch from 0298f22 to 1d56a95 Compare July 31, 2024 10:10
@sergeyberezansky sergeyberezansky force-pushed the sergey/fix-race-on-multi-delete branch from 64afcb5 to 9763acf Compare July 31, 2024 10:17
@sergeyberezansky sergeyberezansky force-pushed the sergey/ocp-machineconfig-fix branch from 1d56a95 to 852b0e7 Compare July 31, 2024 10:20
@sergeyberezansky sergeyberezansky changed the base branch from sergey/fix-race-on-multi-delete to dev July 31, 2024 10:21
Copy link
Collaborator Author

sergeyberezansky commented Jul 31, 2024

Merge activity

@sergeyberezansky sergeyberezansky force-pushed the sergey/ocp-machineconfig-fix branch from 852b0e7 to 9aa68ca Compare July 31, 2024 10:27
@sergeyberezansky sergeyberezansky merged commit 01a82e1 into dev Jul 31, 2024
4 checks passed
@sergeyberezansky sergeyberezansky deleted the sergey/ocp-machineconfig-fix branch July 31, 2024 11:53
@sergeyberezansky sergeyberezansky added bug Something isn't working fix and removed bug Something isn't working labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant