-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CSI-226): support IPv6 in APIclient #287
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sergeyberezansky and the rest of your teammates on Graphite |
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (07/23/24)1 reviewer was added to this PR based on Sergey Berezansky's automation. |
sergeyberezansky
force-pushed
the
sergey/ipv6-support
branch
from
July 23, 2024 10:58
4a7802b
to
fff5566
Compare
sergeyberezansky
force-pushed
the
sergey/fix-race-on-multi-delete
branch
from
July 28, 2024 09:53
ac5a71b
to
a51ebe3
Compare
sergeyberezansky
force-pushed
the
sergey/ipv6-support
branch
from
July 28, 2024 09:53
fff5566
to
5875118
Compare
This was referenced Jul 28, 2024
sergeyberezansky
force-pushed
the
sergey/ipv6-support
branch
from
July 28, 2024 15:58
5875118
to
a422367
Compare
sergeyberezansky
changed the base branch from
sergey/fix-race-on-multi-delete
to
sergey/allow-wekapp-lint
July 28, 2024 15:58
sergeyberezansky
force-pushed
the
sergey/ipv6-support
branch
from
July 28, 2024 16:05
a422367
to
f4ebe2a
Compare
sergeyberezansky
force-pushed
the
sergey/allow-wekapp-lint
branch
2 times, most recently
from
July 29, 2024 06:08
45e9098
to
59acf13
Compare
sergeyberezansky
force-pushed
the
sergey/ipv6-support
branch
from
July 29, 2024 06:08
f4ebe2a
to
05baecc
Compare
sergeyberezansky
force-pushed
the
sergey/allow-wekapp-lint
branch
from
July 29, 2024 06:11
59acf13
to
3fb2650
Compare
sergeyberezansky
force-pushed
the
sergey/ipv6-support
branch
from
July 29, 2024 06:11
05baecc
to
ec6fb4f
Compare
sergeyberezansky
force-pushed
the
sergey/allow-wekapp-lint
branch
6 times, most recently
from
July 30, 2024 07:25
ed317d8
to
c47827d
Compare
This was referenced Jul 30, 2024
sergeyberezansky
force-pushed
the
sergey/allow-wekapp-lint
branch
from
July 30, 2024 07:26
c47827d
to
0f55560
Compare
sergeyberezansky
force-pushed
the
sergey/ipv6-support
branch
from
July 30, 2024 07:39
ec6fb4f
to
427e305
Compare
sergeyberezansky
force-pushed
the
sergey/allow-wekapp-lint
branch
from
July 31, 2024 05:32
0f55560
to
c3025e4
Compare
sergeyberezansky
force-pushed
the
sergey/ipv6-support
branch
from
July 31, 2024 05:32
427e305
to
9d145cf
Compare
sergeyberezansky
force-pushed
the
sergey/allow-wekapp-lint
branch
from
July 31, 2024 08:34
c3025e4
to
f5df6a4
Compare
sergeyberezansky
force-pushed
the
sergey/ipv6-support
branch
from
July 31, 2024 08:34
9d145cf
to
0a2db93
Compare
sergeyberezansky
force-pushed
the
sergey/allow-wekapp-lint
branch
from
July 31, 2024 08:44
f5df6a4
to
5c9d630
Compare
sergeyberezansky
force-pushed
the
sergey/ipv6-support
branch
from
July 31, 2024 08:44
0a2db93
to
597fc57
Compare
sergeyberezansky
force-pushed
the
sergey/allow-wekapp-lint
branch
from
July 31, 2024 10:11
5c9d630
to
aa481f1
Compare
sergeyberezansky
force-pushed
the
sergey/ipv6-support
branch
from
July 31, 2024 10:12
597fc57
to
5758268
Compare
sergeyberezansky
force-pushed
the
sergey/allow-wekapp-lint
branch
from
July 31, 2024 10:21
aa481f1
to
486eec8
Compare
sergeyberezansky
force-pushed
the
sergey/ipv6-support
branch
from
July 31, 2024 10:22
5758268
to
a2a1190
Compare
sergeyberezansky
force-pushed
the
sergey/allow-wekapp-lint
branch
from
July 31, 2024 10:30
486eec8
to
2f6af40
Compare
sergeyberezansky
force-pushed
the
sergey/ipv6-support
branch
from
July 31, 2024 10:31
a2a1190
to
8514c07
Compare
sergeyberezansky
force-pushed
the
sergey/allow-wekapp-lint
branch
from
July 31, 2024 10:34
2f6af40
to
72ba000
Compare
sergeyberezansky
force-pushed
the
sergey/ipv6-support
branch
from
July 31, 2024 10:34
8514c07
to
60f1999
Compare
sergeyberezansky
force-pushed
the
sergey/allow-wekapp-lint
branch
from
July 31, 2024 10:42
72ba000
to
ce1f498
Compare
sergeyberezansky
force-pushed
the
sergey/ipv6-support
branch
from
July 31, 2024 10:43
60f1999
to
4c8a15f
Compare
Merge activity
|
sergeyberezansky
force-pushed
the
sergey/allow-wekapp-lint
branch
from
July 31, 2024 10:52
ce1f498
to
7a1cd02
Compare
sergeyberezansky
force-pushed
the
sergey/ipv6-support
branch
from
July 31, 2024 10:54
4c8a15f
to
390839d
Compare
sergeyberezansky
added
enhancement
New feature or request
feature
and removed
enhancement
New feature or request
labels
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR adds validation functions to check for valid IPv4, IPv6 addresses, and hostnames in the
resetDefaultEndpoints
method and skips endpoints that do not pass validation.What changed?
isValidIPv4Address
,isValidIPv6Address
, andisValidHostname
functions.resetDefaultEndpoints
method to utilize these validation functions and skip invalid endpoints.How to test?
Why make this change?