Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small updates #1573

Merged
merged 28 commits into from
Apr 28, 2019
Merged

Small updates #1573

merged 28 commits into from
Apr 28, 2019

Conversation

Borewit
Copy link
Member

@Borewit Borewit commented Apr 25, 2019

To simplify the review process I combined a set of small outstanding Pull Request in this Pull Request.

Please note that this does not change a thing to the credits of the original PR. Included PR's will automatically closed upon merging this one. In other words, merging these PR will have the exact same effect as merging the listed PR's individually directly to the master branch.

PR's included (combined):

  1. Update music metadata #1572 Update music-metadata
  2. Remove '(BETA)' from app window title #1562 Remove '(BETA)' from app window title
  3. Update copyright for 2019 #1546 Update copyright for 2019
  4. Green keeper PR's:
    1. Update cp-file to the latest version 🚀 #1569 Update cp-file to the latest version
    2. Update iso-639-1 to the latest version 🚀 #1561 Update iso-639-1 to the latest version
    3. Update semver to the latest version 🚀 #1559 Update semver to the latest version
    4. Update opn to the latest version 🚀 #1558 Update opn to the latest version
    5. Update walk-sync to the latest version 🚀 #1542 Update walk-sync to the latest version
    6. Update depcheck to the latest version 🚀 #1548 Update depcheck to the latest version

greenkeeper bot and others added 27 commits February 5, 2019 03:46
… small-updates

# Conflicts:
#	package-lock.json
@Borewit Borewit self-assigned this Apr 25, 2019
@Borewit Borewit requested review from mathiasvr and dcposch April 25, 2019 18:21
@codealchemist
Copy link
Contributor

Left a comment for a really quick fix.
Also did a smoke test on OSX and it went well.
Thanks @Borewit !

@Borewit
Copy link
Member Author

Borewit commented Apr 27, 2019

Left a comment for a really quick fix.

Sure, but I can't find it. Can you let me know or apply the fix?

Thanks a lot for reviewing @DiegoRBaquero, @jimmywarting & @codealchemist

@Borewit Borewit removed the request for review from dcposch April 27, 2019 09:07
Copy link
Contributor

@codealchemist codealchemist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added missing dots for supported media types.

src/renderer/lib/media-extensions.js Outdated Show resolved Hide resolved
@Borewit Borewit merged commit c7ef42a into master Apr 28, 2019
@Borewit Borewit deleted the small-updates branch May 15, 2019 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants