Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copyright for 2019 #1546

Merged
merged 1 commit into from
Apr 28, 2019
Merged

Update copyright for 2019 #1546

merged 1 commit into from
Apr 28, 2019

Conversation

dsernst
Copy link
Contributor

@dsernst dsernst commented Feb 23, 2019

1 character fix to update the copyright line from 2014-2018 to 2014-2019 💅

Here are the two places this value is used: https://github.com/webtorrent/webtorrent-desktop/search?q=APP_COPYRIGHT&unscoped_q=APP_COPYRIGHT

Happy new year everybody 🎉🍾🚀

@welcome
Copy link

welcome bot commented Feb 23, 2019

🙌 Thanks for opening this pull request! You're awesome.

Copy link

@trujamal trujamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General

  • Does the code work?
  • Is all the code easily understood?
  • Does it conform to your agreed coding conventions?
  • Is there any redundant or duplicate code?
  • Is the code as modular as possible?
  • Can any global variables be replaced?
  • Is there any commented out code?
  • Do loops have a set length and correct termination conditions?
  • Do the names used in the program convey intent?

Performance

  • Are there any obvious optimizations that will improve performance?
  • Can any of the code be replaced with library or built-in functions?
  • Can any logging or debugging code be removed?

Security

  • Are all data inputs checked (for the correct type, length, format, and range) and encoded?
  • Where third-party utilities are used, are returning errors being caught?
  • Are output values checked and encoded?
  • Are invalid parameter values handled?

Documentation

  • Do comments exist and describe the intent of the code?
  • Are all functions commented?
  • Is any unusual behavior or edge-case handling described?
  • Is the use and function of third-party libraries documented?
  • Are data structures and units of measurement explained?
  • Is there any incomplete code? If so, should it be removed or flagged with a suitable marker like ‘TODO’?

Testing

  • Is the code testable? The code should be structured so that it doesn’t add too many or hide dependencies, is unable to initialize objects, test frameworks can use methods etc.
  • Do tests exist, and are they comprehensive?
  • Do unit tests actually test that the code is performing the intended functionality?
  • Could any test code be replaced with the use of an existing API?

@Borewit Borewit mentioned this pull request Apr 25, 2019
@Borewit Borewit merged commit 0e3962e into webtorrent:master Apr 28, 2019
@welcome
Copy link

welcome bot commented Apr 28, 2019

🎉 Congrats on getting your first pull request landed!

@lock lock bot locked as resolved and limited conversation to collaborators Jul 27, 2019
@dsernst dsernst deleted the patch-1 branch July 31, 2020 02:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants