Catch uWSGI TypeError for invalid headers #603
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch TypeError thrown by uWSGI in addition to UnicodeError
Motivation and Context
The fix for invalid headers merged with #536 seems not to be working with Docker/uWSGI/Python3. Looking at https://github.com/unbit/uwsgi/blob/master/plugins/python/wsgi_headers.c#L140, uWSGI is throwing a TypeError, not a UnicodeError. However, UnicodeError is correct when not using uWSGI (e.g. run with cli.py).
Catching the TypeError solves the replay problem also when running pywb with Docker/uWSGI/Python3.
Types of changes
Checklist: