Try to remove headers with illegal characters. #536
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Try to remove headers with illegal characters. Fixing the following issue arquivo/pwa-technologies#774
Motivation and Context
Pywb is not able replay records with illegal characters (outside latin1) in the replay headers.
In example above there is a Trademark character on the Server header that breaks the streaming of the response.
This change try to fix those badly formed headers, detecting them and removing them. Its a best enforce approach, in last case the record will fail to load as it was.
arquivo/pwa-technologies#774
Screenshots (if appropriate):
After this fix:
Types of changes
I am not sure if this is the best approach, open to do any change needed to make it go upstream.