docs(config) document devServer options injectClient and injectHot #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranshuchittora
approved these changes
May 5, 2019
|
Preview is ready Built with commit ef09119 https://deploy-preview-2996--webpackjsorg-netlify.netlify.com |
anshumanv
approved these changes
May 9, 2019
hiroppy
reviewed
May 9, 2019
| module.exports = { | ||
| //... | ||
| devServer: { | ||
| injectHot: (compilerConfig) => compilerConfig.name === 'only-include' |
There was a problem hiding this comment.
Please add hot because injectHot is used when HMR is enabled.
There was a problem hiding this comment.
Great catch @hiroppy
I've pushed an update
hiroppy
reviewed
May 10, 2019
| }; | ||
| ``` | ||
|
|
||
| W> Make sure that [`devServer.hot`](#devserverhot) is set to `true` because `devServer.injectHot` only works with HMR. |
There was a problem hiding this comment.
You can see it in preview mate, or check out https://webpack.js.org/contribute/writers-guide
There was a problem hiding this comment.
Oops, thank you for the explanation.
hiroppy
approved these changes
May 12, 2019
|
We have released [email protected], so I remove |
|
Amazing, ty @hiroppy |
|
Thanks everyone invlolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes two off #2974
Documents devServer options injectClient and injectHot
ON HOLD due to waiting dev server release.