Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation of sockPort, injectClient, and injectHot #2974

Closed
hiroppy opened this issue Apr 26, 2019 · 6 comments
Closed

Add documentation of sockPort, injectClient, and injectHot #2974

hiroppy opened this issue Apr 26, 2019 · 6 comments

Comments

@hiroppy
Copy link
Member

hiroppy commented Apr 26, 2019

Feature to document

Add new options's descriptions of webpack-dev-server.

sockPort, injectClient, and injectHot

Author(s)

/cc @evilebottnawi

Additional information

related: webpack/webpack-dev-server#1821

@EugeneHlushko
Copy link
Member

@hiroppy wanna file a PR or should we pick it up?

@EugeneHlushko
Copy link
Member

EugeneHlushko commented May 5, 2019

@hiroppy
Copy link
Member Author

hiroppy commented May 9, 2019

I missed the message. I'm sorry. Thank you for adding these to the document.

@EugeneHlushko
Copy link
Member

done, closing

@IronSean
Copy link

I still have no idea what these do though, even with the documentation

@jpierson
Copy link

Agreed @IronSean. I just ran into an issue getting a library working with webpack-dev-server and ran into the injectClient following the thread for webpack/webpack-dev-server#2484. As it turns it, it seems to have fixed the problem I was running into by setting this to false but I have no idea why really. Better documentation here would most likely help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants