Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proxy): add arguments to proxyconfig #2714

Merged
merged 1 commit into from
Aug 20, 2020
Merged

feat(proxy): add arguments to proxyconfig #2714

merged 1 commit into from
Aug 20, 2020

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Aug 20, 2020

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yep

Motivation / Use-Case

closes: #2369

Breaking Changes

no

Additional Info

@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #2714 into v4 will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v4    #2714   +/-   ##
=======================================
  Coverage   92.88%   92.88%           
=======================================
  Files          37       37           
  Lines        1293     1293           
  Branches      344      344           
=======================================
  Hits         1201     1201           
  Misses         88       88           
  Partials        4        4           
Impacted Files Coverage Δ
lib/Server.js 96.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1105309...bc043cb. Read the comment docs.

@hiroppy hiroppy force-pushed the feature/update-proxy branch from 3dbda4b to 19fa1b3 Compare August 20, 2020 07:23
@hiroppy hiroppy force-pushed the feature/update-proxy branch from 19fa1b3 to bc043cb Compare August 20, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants