Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): proxyconfig callback args #2369

Closed
wants to merge 4 commits into from

Conversation

RavenHursT
Copy link

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

This allows configuration of the proxy to be dynamic based off the Express req, res, and next args.

#2360 (comment)

Breaking Changes

None

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@codecov
Copy link

codecov bot commented Dec 23, 2019

Codecov Report

Merging #2369 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2369   +/-   ##
=======================================
  Coverage   93.95%   93.95%           
=======================================
  Files          34       34           
  Lines        1291     1291           
  Branches      368      368           
=======================================
  Hits         1213     1213           
  Misses         77       77           
  Partials        1        1
Impacted Files Coverage Δ
lib/Server.js 97.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 453b41e...aa2ca92. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be great to have test where we check req, res and next (for example simple integration test)

@hiroppy
Copy link
Member

hiroppy commented Aug 20, 2020

Thank you for your contribution. closed via #2714

@hiroppy hiroppy closed this Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants