BREAKING CHANGE: use this.options.xxx

[hiroppy]

• This is a bugfix
• This is a feature
• This is a code refactor
• This is a test update
• This is a docs update
• This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

Use this.options.xxx instead of this.xxx.

Breaking Changes

yes

Additional Info

[codecov]

Codecov Report

Merging #2558 into v4 will decrease coverage by 0.19%.
The diff coverage is 93.87%.

@@            Coverage Diff             @@
##               v4    #2558      +/-   ##
==========================================
- Coverage   92.55%   92.36%   -0.20%     
==========================================
  Files          35       35              
  Lines        1330     1323       -7     
  Branches      375      376       +1     
==========================================
- Hits         1231     1222       -9     
- Misses         94       96       +2     
  Partials        5        5              

Impacted Files	Coverage Δ
lib/servers/WebsocketServer.js	94.11% <ø> (ø)
lib/Server.js	96.51% <92.10%> (-0.37%)	⬇️
lib/utils/normalizeOptions.js	96.87% <100.00%> (-3.13%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e826119...7e66e8a. Read the comment docs.

[hiroppy]

I'll work on this after merging #2531, because transportMode is broken in this pr.

[alexander-akait]

/cc @hiroppy Merged 👍

[hiroppy]

hm, If we modify the sockPath(overwriting to this.options.sockPath), webpack-dev-server will be broken maybe... @Loonride can you know why this causes?

[knagaitsev]

hm, If we modify the sockPath(overwriting to this.options.sockPath), webpack-dev-server will be broken maybe... @Loonride can you know why this causes?

@hiroppy I'm not sure, where is it being modified exactly? Maybe the webpack entry is being created with that sockPath before it is modified

Maybe my handling of sockPath here can solve the problem for you: #2593

[hiroppy]

@Loonride thanks, I'll check this pr again after merging #2593

[hiroppy]

CI is green. Thanks, @Loonride. So don't merge this before merging #2593.

[alexander-akait]

/cc @hiroppy Merged 👍

[hiroppy]

@evilebottnawi Updated!

[alexander-akait]

Good work!