BREAKING CHANGE: switch default transportMode to ws

[knagaitsev]

• This is a bugfix
• This is a feature
• This is a code refactor
• This is a test update
• This is a docs update
• This is a metadata update

For Bugs and Features; did you add new tests?

No

Motivation / Use-Case

switching to ws as default

this may require getting rid of iframe to pass tests since I think iframe mode relies on sockjs

Should the warning that transportMode is an experimental option stay for the moment, or should we get rid of it?

Breaking Changes

ws will be default instead of sockjs

Edit: also changed default sockPath from sockjs-node to ws

Additional Info

[codecov]

Codecov Report

Merging #2531 into v4 will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##               v4    #2531   +/-   ##
=======================================
  Coverage   93.43%   93.43%           
=======================================
  Files          34       34           
  Lines        1309     1309           
  Branches      369      369           
=======================================
  Hits         1223     1223           
  Misses         83       83           
  Partials        3        3           

Impacted Files	Coverage Δ
lib/utils/createConfig.js	96.19% <ø> (ø)
lib/utils/getSocketServerImplementation.js	90.47% <ø> (ø)
client-src/default/utils/createSocketUrl.js	100.00% <100.00%> (ø)
lib/Server.js	96.73% <100.00%> (ø)
lib/utils/addEntries.js	100.00% <100.00%> (ø)
lib/utils/normalizeOptions.js	100.00% <100.00%> (ø)
lib/utils/routes.js	92.30% <100.00%> (ø)
lib/utils/updateCompiler.js	100.00% <100.00%> (ø)
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 308ee21...96a53be. Read the comment docs.

[alexander-akait]

@Loonride hm, CI broken

[alexander-akait]

/cc @Loonride friendly ping

[knagaitsev]

/cc @Loonride friendly ping

Yes it made sense to get rid of iframe/live mode first, since it relied on sockjs I believe

[alexander-akait]

Great job!

[p-szm]

@Loonride @hiroppy @alexander-akait I've recently upgraded my WDS to 4.x and I stated seeing issues with the websocket randomly dying when the server is running. Switching back to sockjs works, but I'm just curious what was the reason for changing the default to websockets?

[snitin315]

Switching back to sockjs works, but I'm just curious what was the reason for changing the default to websockets?

@patrickszmucer Are you using any 3rd party plugin like the error-overlay-webpack-plugin?

[p-szm]

I'm not - I have error overlays disabled and I wrote some custom code that listens to these events and changes the color of my banner to show when the server is ready/reloading/stopped. I noticed that the banner now occasionally flickers between stopped/ready because I'm getting "webscket close" events (with a 1006 status).

[snitin315]

Please create an issue with reproducible example.

[p-szm]

Will do - I just need to collect more details. I was just curious about the motivation for this change :)