Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .nyc_output to .npmignore #354

Closed
wants to merge 1 commit into from
Closed

Conversation

amilajack
Copy link

@amilajack amilajack commented Mar 19, 2018

What kind of change does this PR introduce?
build related change

Did you add tests for your changes?
no

If relevant, did you update the documentation?

Summary
Flow fails when parsing the node_modules/webpack-cli

Does this PR introduce a breaking change?
no

@jsf-clabot
Copy link

jsf-clabot commented Mar 19, 2018

CLA assistant check
All committers have signed the CLA.

@webpack-bot
Copy link

@amilajack Please review the following output log for errors:

> [email protected] travis:integration /home/travis/build/webpack/webpack-cli
> nyc jest && npm run reportCoverage

 PASS  lib/utils/ast-utils.test.js (18.345s)
 PASS  lib/init/transformations/watch/watchOptions.test.js (25.409s)
 PASS  lib/init/transformations/module/module.test.js (27.201s)
 PASS  lib/utils/is-local-path.test.js (15.443s)
 PASS  lib/migrate/uglifyJsPlugin/uglifyJsPlugin.test.js
 PASS  lib/migrate/bannerPlugin/bannerPlugin.test.js
 PASS  lib/utils/resolve-packages.test.js (21.84s)
 PASS  lib/init/transformations/top-scope/top-scope.test.js (14.888s)
 PASS  lib/utils/npm-exists.test.js (21.887s)
 PASS  lib/migrate/resolve/resolve.test.js (7.637s)
 PASS  lib/migrate/extractTextPlugin/extractTextPlugin.test.js (8.716s)
 PASS  lib/utils/package-manager.test.js (30.503s)
 PASS  lib/init/transformations/watch/watch.test.js (32.121s)
 PASS  lib/migrate/outputPath/outputPath.test.js (18.958s)
 PASS  lib/init/transformations/node/node.test.js (31.746s)
 PASS  lib/init/transformations/entry/entry.test.js (35.951s)
 PASS  lib/init/transformations/externals/externals.test.js (36.666s)
 PASS  lib/migrate/removeJsonLoader/removeJsonLoader.test.js (34.499s)
 PASS  lib/init/transformations/target/target.test.js (36.09s)
 PASS  lib/init/transformations/stats/stats.test.js (40.517s)
 PASS  lib/init/transformations/devtool/devtool.test.js (38.292s)
 PASS  lib/init/transformations/context/context.test.js (37.303s)
 PASS  lib/migrate/loaderOptionsPlugin/loaderOptionsPlugin.test.js (36.865s)
 PASS  lib/init/transformations/mode/mode.test.js (37.286s)
 PASS  lib/init/transformations/resolveLoader/resolveLoader.test.js (38.337s)
 PASS  lib/init/transformations/performance/performance.test.js (39.562s)
 PASS  lib/init/transformations/plugins/plugins.test.js (38.742s)
 PASS  lib/init/transformations/resolve/resolve.test.js (40.678s)
 PASS  lib/init/transformations/devServer/devServer.test.js (40.385s)
 PASS  lib/init/transformations/output/output.test.js (40.51s)
 PASS  lib/migrate/removeDeprecatedPlugins/removeDeprecatedPlugins.test.js (39.314s)
  ● Console

    console.log lib/migrate/removeDeprecatedPlugins/removeDeprecatedPlugins.js:37
      
      Please remove deprecated plugins manually. 
      See https://webpack.js.org/guides/migrating/ for more information.
    console.log lib/migrate/removeDeprecatedPlugins/removeDeprecatedPlugins.js:37
      
      Please remove deprecated plugins manually. 
      See https://webpack.js.org/guides/migrating/ for more information.
    console.log lib/migrate/removeDeprecatedPlugins/removeDeprecatedPlugins.js:37
      
      Please remove deprecated plugins manually. 
      See https://webpack.js.org/guides/migrating/ for more information.

 PASS  lib/generators/loader-generator.test.js (40.267s)
 PASS  lib/migrate/index.test.js (42.399s)
 PASS  lib/migrate/loaders/loaders.test.js (40.766s)
 PASS  lib/init/transformations/other/other.test.js (43.478s)
 PASS  lib/utils/npm-packages-exists.test.js (54.989s)
 PASS  test/BinTestCases.test.js (212.799s)
�[999D�[K
=============================== Coverage summary ===============================
Statements   : 77.18% ( 1265/1639 )
Branches     : 62.15% ( 509/819 )
Functions    : 75.42% ( 313/415 )
Lines        : 77.16% ( 1253/1624 )
===

See complete report here.

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR @amilajack ! Could you add other misc stuff to this as well? Like the jsdoc.json, MIGRATE.MD and everything that isn't compiled source code? Thanks!

@evenstensberg
Copy link
Member

Closing in favor for #349 . Thanks for the PR! Can I grab you another issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants