chore(pkg): explicitly include files for release

[rgbkrk]

What kind of change does this PR introduce?

Build related change

Did you add tests for your changes?

N/A

If relevant, did you update the documentation?

N/A

Summary

When running flow in a project that uses webpack-cli, the latest release is causing flow to choke on a non-valid json file:

> flow

Launching Flow server for /Users/kylek/code/src/github.com/nteract/nteract-ext
Spawned flow server (pid=10402)
Logs will go to /private/tmp/flow/zSUserszSkylekzScodezSsrczSgithub.comzSnteractzSnteract-ext.log
Monitor logs will go to /private/tmp/flow/zSUserszSkylekzScodezSsrczSgithub.comzSnteractzSnteract-ext.monitor_log
Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ node_modules/webpack-cli/.nyc_output/8f27269b188e61a59bbf5827de818c30.json:1:1

Unexpected end of input

     1│

Since that file shouldn't be part of the release, I added the .nyc_output directory to the npm ignore.

Does this PR introduce a breaking change?

Nope.

[jsf-clabot]

All committers have signed the CLA.

[dhruvdutt]

Please sign CLA and use commitlint for linting commit messages. You can use git cz for an interactive commit or use one of these.

[evenstensberg]

Thanks!

[rgbkrk]

@dhruvdutt would you say this is a chore or a fix?

[dhruvdutt]

chore

[evenstensberg]

Heyo, didn't read this. Seems to be another PR for this #354 . Could you do the thing I mentioned there? First one to implement gets a lgtm 😄

[rgbkrk]

Rebased with requested commit style.

[dhruvdutt]

@rgbkrk Do check what Even has mentioned in his review on #354

[rgbkrk]

Yeah I just added on the ones @ev1stensberg explicitly mentioned, looking into what else is misc though I'm sure you'll be able to rattle off which you don't want more easily as a maintainer.

Do you want docs in the packaged release?

Looking again, jsdoc.json was already in there, so I'm rebasing again.

[dhruvdutt]

LGTM.

[dhruvdutt]

@rgbkrk docs are already included in npmignore file.
You can also clean up things from npmignore that are already included in .gitignore like .vscode

[rgbkrk]

Alright, I've organized the npmignore more like the gitignore.

[dhruvdutt]

Uh! I might not have explained it in the best way.
I meant to clean up or not include things that are already listed in gitignore. For instance, .vscode is currently mentioned in both npmignore and gitignore but if it's in gitignore then it won't be in version control or on GitHub in the first place hence we don't need to mention it in npmignore.

[webpack-bot]

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

[rgbkrk]

Do you publish from a developer laptop or from CI?

[dhruvdutt]

IMO we publish manually. You can see the list of npm publishers here.

[ooflorent]

Why not using files field from package.json? It would simplify the maintenance.

[evenstensberg]

Consider revising this

[webpack-bot]

@rgbkrk Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ev1stensberg Please review the new changes.

[rgbkrk]

Switched this over to using files in the package.json. Note that README.md and certain other files are automatically included and do not have to be explicitly stated in files.

[dhruvdutt]

LGTM.

[rgbkrk]

Just to follow up, even though we're using files now:

Do you publish from a developer laptop or from CI?

IMO we publish manually. You can see the list of npm publishers here.

Since a .npmignore overrides what's in a .gitignore, if a developer has files locally that shouldn't be in the package yet are git ignored, they'll accidentally upload them as part of the package. Some files npm makes sure to avoid .DS_Store, swap files, etc. Since that's a bit of a hairy mess to figure out continuously, the files approach is definitely better.

[ematipico]

Amazing job! Thanks!!

[evenstensberg]

webpack-cli @2.0.13

[rgbkrk]

Thanks!

[evenstensberg]

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀