Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add webpack as a devDependency #76

Merged
merged 2 commits into from
Jul 6, 2017

Conversation

mattlewis92
Copy link
Member

@mattlewis92 mattlewis92 commented Jun 25, 2017

Continuing the discussion from webpack-contrib/less-loader#208 (comment)

I believe webpack should be included as a dev dependency because:

  • checking out a webpack-contrib repo, running npm install and npm t should just work. Instead you're greeted with this error message, it's not immediately obvious that webpack needs to be installed with npm install webpack. Some users will just give up here and not bother contributing to the repo.

screen shot 2017-06-25 at 10 59 41

  • secondly once running npm install webpack to get the tests running, because of the npm 5 requirement, package.json and package-lock.json are automatically updated and will appear in the git diff before the user has even made any changes. Based on my own experience with open source, people will commit these changes in a pull request, and it's going to lead to maintainers asking contributors to remove these files in reviews which is just a waste of everyones time and energy.

I can't really see any advantages to not having it installed as a dev dependency, travis already automatically tests the repo against all supported versions of webpack and will catch the rare time something is broken on an older version of webpack.

Closes #78

@michael-ciniawsky michael-ciniawsky changed the title feat: add webpack as a dev dependency feat: add webpack as a devDependency Jun 25, 2017
@joshwiens
Copy link
Member

joshwiens commented Jul 4, 2017

I think the general consensus after talking about this in Slack is we'll add it as a devDep & move the burden of explicit versions / dev versions / whatever onto the maintainers.

My only concern, if you can call it that is given we have 51 maintained repos and climbing this should probable be set to latest as well.

It's a pipe dream to think we are going to have time / always remember to bump the dev dependency to keep up with Webpack releases.

@mattlewis92 - DM me a email on Twitter ( same name ), i'll get you a slack invite.

@joshwiens joshwiens merged commit bc8a415 into webpack-contrib:master Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants