feat: add webpack
as a devDependency
#76
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the discussion from webpack-contrib/less-loader#208 (comment)
I believe webpack should be included as a dev dependency because:
npm install
andnpm t
should just work. Instead you're greeted with this error message, it's not immediately obvious that webpack needs to be installed withnpm install webpack
. Some users will just give up here and not bother contributing to the repo.npm install webpack
to get the tests running, because of the npm 5 requirement,package.json
andpackage-lock.json
are automatically updated and will appear in the git diff before the user has even made any changes. Based on my own experience with open source, people will commit these changes in a pull request, and it's going to lead to maintainers asking contributors to remove these files in reviews which is just a waste of everyones time and energy.I can't really see any advantages to not having it installed as a dev dependency, travis already automatically tests the repo against all supported versions of webpack and will catch the rare time something is broken on an older version of webpack.
Closes #78