chore(package): update `defaults 1.4.0` support Webpack@3 #208

mattlewis92 · 2017-06-20T14:14:35Z

No description provided.

jsf-clabot · 2017-06-20T14:14:36Z

All committers have signed the CLA.

codecov · 2017-06-20T14:20:28Z

Codecov Report

Merging #208 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
- Coverage   97.93%   97.84%   -0.09%     
==========================================
  Files           7        8       +1     
  Lines          97       93       -4     
  Branches        9        9              
==========================================
- Hits           95       91       -4     
  Misses          2        2

Impacted Files	Coverage Δ
src/index.js	`88.88% <ø> (-3.97%)`	⬇️
src/cjs.js	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83837f7...908b8b0. Read the comment docs.

michael-ciniawsky · 2017-06-20T14:37:55Z

.travis.yml

@@ -7,8 +7,8 @@ matrix:
  fast_finish: true


Could you revert the travis.yml changes please, we have a organsation wide upgrade solution for this in place :)

bebraw

It would be better to update webpack-defaults and then npm run webpack-defaults to pull the changes.

mattlewis92 · 2017-06-20T14:47:29Z

@bebraw done (on a side note webpack-defaults is an awesome idea for keeping multiple repos up to date with the same scaffolding! 👍 )

michael-ciniawsky

@mattlewis92 Thx

michael-ciniawsky · 2017-06-20T16:18:26Z

package.json

@@ -3,29 +3,29 @@
  "version": "4.0.4",
  "author": "Johannes Ewald @jhnns",
  "description": "Less loader for webpack. Compiles Less to CSS.",
-  "main": "dist/index.js",
+  "main": "dist/cjs.js",
  "scripts": {
    "create-spec": "babel-node test/helpers/createSpec.js",
    "pretest": "npm run create-spec",


The create-spec (pretest) script doesn't seem to run on the PART=coverage build https://travis-ci.org/webpack-contrib/less-loader/jobs/244975479

Ah I was wondering why that was failing, should be fixed now! 😄

mattlewis92 · 2017-06-20T21:00:18Z

Got the appveyor tests passing (had to remove the quote marks added to commands + use npm 5). I also removed the cjs.js file as this lib doesn't actually use import + export syntax so it would have failed when published as no module.exports.default would have been created. I think this should be good to go now.

joshwiens · 2017-06-24T03:30:20Z

For reference, if it touches source code in any way ( to include import ) it is not a chore.

mattlewis92 · 2017-06-24T10:48:17Z

@d3viant0ne I've made the requested changes in appveyor.yml but left off removing the webpack dev dependency for now. I saw the discussion about the module exports babel plugin in webpack-contrib/webpack-defaults#23 so I won't bother making an issue there as I can see it's already been discussed 😄

halfred888 · 2017-06-30T13:03:10Z

👍 waiting for merge :) ⏳

michael-ciniawsky · 2017-07-01T00:20:44Z

package.json

-    "release": "yarn run standard-version",
+    "prebuild": "npm run clean",
+    "prepublish": "npm run build",
+    "release": "standard-version",
    "security": "nsp check",
    "serve:dev": "nodemon $2 --exec babel-node",


Can be removed :)

michael-ciniawsky · 2017-07-01T00:20:55Z

package.json

    "lint": "eslint --cache src test",
    "webpack-defaults": "webpack-defaults",
-    "start": "yarn run build -- -w",
+    "start": "npm run build -- -w",
    "build": "cross-env NODE_ENV=production babel src -d dist --ignore 'src/**/*.test.js'",
    "clean:dist": "del-cli dist",


Can be removed :), bc of https://github.com/webpack-contrib/less-loader/pull/208/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R30

mattlewis92 · 2017-07-06T19:15:05Z

I've updated webpack-defaults to pull in the latest changes from there. There is a bug with npm 5.0.x though that was making the CI fail so I had to force appveyor and travis to use npm 5.1.0, once the next node 8.x is released with npm 5.1.0 included these 2 hacks can be removed (by running npm run webpack-defaults)

joshwiens · 2017-07-06T19:20:08Z

@mattlewis92 - I'll fix the npm version issue upstream.

mattlewis92 force-pushed the webpack3 branch from cd9ea28 to 2f901c4 Compare June 20, 2017 14:20

michael-ciniawsky changed the title ~~feat: allow webpack3 peer dependency~~ chore(package): update devDependencies && peerDependencies (webpack v2.3.2...3.0.0) Jun 20, 2017

michael-ciniawsky requested changes Jun 20, 2017

View reviewed changes

michael-ciniawsky added priority: 2 (urgent) pr_action: Review semver: Patch type: Chore labels Jun 20, 2017

michael-ciniawsky assigned alexander-akait Jun 20, 2017

michael-ciniawsky requested review from bebraw, alexander-akait and joshwiens June 20, 2017 14:39

mattlewis92 force-pushed the webpack3 branch from 2f901c4 to 729b753 Compare June 20, 2017 14:41

bebraw reviewed Jun 20, 2017

View reviewed changes

mattlewis92 force-pushed the webpack3 branch from 729b753 to c697eda Compare June 20, 2017 14:45

bebraw approved these changes Jun 20, 2017

View reviewed changes

michael-ciniawsky changed the title ~~chore(package): update devDependencies && peerDependencies (webpack v2.3.2...3.0.0)~~ chore(package): update webpack-defaults v1.0.1...1.4.0&& peerDependencies (webpack v3.0.0) Jun 20, 2017

michael-ciniawsky approved these changes Jun 20, 2017

View reviewed changes

michael-ciniawsky changed the title ~~chore(package): update webpack-defaults v1.0.1...1.4.0&& peerDependencies (webpack v3.0.0)~~ chore(package): update webpack-defaults v1.0.1...1.4.0 && peerDependencies (webpack v3.0.0) Jun 20, 2017

mattlewis92 force-pushed the webpack3 branch from c697eda to 24facb0 Compare June 20, 2017 14:57

alexander-akait approved these changes Jun 20, 2017

View reviewed changes

michael-ciniawsky reviewed Jun 20, 2017

View reviewed changes

mattlewis92 force-pushed the webpack3 branch 5 times, most recently from de843fe to 544f96f Compare June 20, 2017 20:50

joshwiens added type: Refactor and removed priority: 2 (urgent) type: Chore labels Jun 24, 2017

mattlewis92 force-pushed the webpack3 branch from 9ac2585 to 20e25e8 Compare June 24, 2017 10:41

mattlewis92 force-pushed the webpack3 branch from 20e25e8 to d06008a Compare June 25, 2017 09:42

michael-ciniawsky reviewed Jul 1, 2017

View reviewed changes

michael-ciniawsky requested a review from jhnns July 1, 2017 00:22

joshwiens approved these changes Jul 2, 2017

View reviewed changes

joshwiens added pr_action: Merge ready and removed pr_action: Rework labels Jul 3, 2017

mattlewis92 force-pushed the webpack3 branch 7 times, most recently from 1ddf26e to 56288ae Compare July 6, 2017 18:54

feat: update peer dependencies to support webpack 3

908b8b0

mattlewis92 force-pushed the webpack3 branch from 56288ae to 908b8b0 Compare July 6, 2017 19:01

joshwiens changed the title ~~chore(package): update webpack-defaults v1.0.1...1.4.0 && peerDependencies (webpack v3.0.0)~~ chore(package): update defaults 1.4.0 support Webpack@3 Jul 10, 2017

joshwiens merged commit 643c00b into webpack-contrib:master Jul 10, 2017

mattlewis92 mentioned this pull request Jul 20, 2017

chore: Update to webpack-defaults 1.6 #212

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(package): update `defaults 1.4.0` support Webpack@3 #208

chore(package): update `defaults 1.4.0` support Webpack@3 #208

mattlewis92 commented Jun 20, 2017

jsf-clabot commented Jun 20, 2017 •

edited

Loading

codecov bot commented Jun 20, 2017 •

edited

Loading

michael-ciniawsky Jun 20, 2017

bebraw left a comment

mattlewis92 commented Jun 20, 2017

michael-ciniawsky left a comment

michael-ciniawsky Jun 20, 2017

mattlewis92 Jun 20, 2017

mattlewis92 commented Jun 20, 2017

joshwiens commented Jun 24, 2017

mattlewis92 commented Jun 24, 2017

halfred888 commented Jun 30, 2017

michael-ciniawsky Jul 1, 2017

michael-ciniawsky Jul 1, 2017

mattlewis92 commented Jul 6, 2017

joshwiens commented Jul 6, 2017

chore(package): update defaults 1.4.0 support Webpack@3 #208

chore(package): update defaults 1.4.0 support Webpack@3 #208

Conversation

mattlewis92 commented Jun 20, 2017

jsf-clabot commented Jun 20, 2017 • edited Loading

codecov bot commented Jun 20, 2017 • edited Loading

Codecov Report

michael-ciniawsky Jun 20, 2017

Choose a reason for hiding this comment

bebraw left a comment

Choose a reason for hiding this comment

mattlewis92 commented Jun 20, 2017

michael-ciniawsky left a comment

Choose a reason for hiding this comment

michael-ciniawsky Jun 20, 2017

Choose a reason for hiding this comment

mattlewis92 Jun 20, 2017

Choose a reason for hiding this comment

mattlewis92 commented Jun 20, 2017

joshwiens commented Jun 24, 2017

mattlewis92 commented Jun 24, 2017

halfred888 commented Jun 30, 2017

michael-ciniawsky Jul 1, 2017

Choose a reason for hiding this comment

michael-ciniawsky Jul 1, 2017

Choose a reason for hiding this comment

mattlewis92 commented Jul 6, 2017

joshwiens commented Jul 6, 2017

chore(package): update `defaults 1.4.0` support Webpack@3 #208

chore(package): update `defaults 1.4.0` support Webpack@3 #208

jsf-clabot commented Jun 20, 2017 •

edited

Loading

codecov bot commented Jun 20, 2017 •

edited

Loading