Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

docs - adds array type for options.use and options.fallback #394

Merged
merged 1 commit into from
Feb 17, 2017

Conversation

pndewit
Copy link
Contributor

@pndewit pndewit commented Feb 8, 2017

Noticed that documentation is outdated for the options.use and the options.fallback types. As far as I can tell, they should also be able to be an array (especially since they are replacing the fallbackLoader and the loader options and they were able to be arrays): https://github.com/webpack-contrib/extract-text-webpack-plugin/blob/master/schema/loader-schema.js

@codecov
Copy link

codecov bot commented Feb 8, 2017

Codecov Report

Merging #394 into master will not impact coverage.

@@           Coverage Diff           @@
##           master     #394   +/-   ##
=======================================
  Coverage   90.42%   90.42%           
=======================================
  Files           6        6           
  Lines         355      355           
  Branches       74       74           
=======================================
  Hits          321      321           
  Misses         34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e831507...9311650. Read the comment docs.

@pndewit
Copy link
Contributor Author

pndewit commented Feb 8, 2017

/signed CLA
Why is the check below not updated..?

Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pndewit Thx in advance 👍 @bebraw @d3viant0ne some merge please 😛

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants