fix(index): update syntax to match latest rc3 #34
Conversation
| @@ -43,7 +43,7 @@ export = function css({ filename = '[name].css', allChunks = false, sourceMap = | |||
| rules: get(this, 'module.rules', []).concat([{ | |||
| test, | |||
| use: extractCss ? | |||
| extractText.extract({ fallbackLoader: loaders[0], loader: loaders.slice(1) }) : | |||
| extractText.extract({ fallback: loaders[0], use: loaders.slice(1) }) : | |||
There was a problem hiding this comment.
Hmm, can use be an Array? The docs say it's "string / object", not sure what they mean by "object", perhaps it needs to be use: { loaders: [...] }? Could you find this out?
Thanks
There was a problem hiding this comment.
@niieani Good eye, I checked out this: https://github.com/webpack-contrib/extract-text-webpack-plugin/blob/master/schema/loader-schema.js
Documentation must be outdated. I'll send them a PR as well. ;)
|
I'm releasing this fix without testing (shame on me...), I honestly hope you have :) |
|
Created a PR this morning for the docs update: webpack-contrib/extract-text-webpack-plugin#394 I tested this with my project, but that's just one of many use cases of course. |
|
Just a quick update, the docs PR was approved and merged. |
|
Awesome, thanks. |
Latest RC (RC3) of extract-text-webpack-plugin gives a warning when using the fallbackLoader and loader namings. Also updated the dependency to the latest RC.
See: https://github.com/webpack-contrib/extract-text-webpack-plugin/releases/tag/v2.0.0-rc.3