Build: Generate files d.ts
#448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarvaje
requested review from
alrra,
austinkelleher,
molant and
patrick-steele-idem
as code owners
molant
requested changes
Aug 22, 2017
tests/helpers/test-server.ts
Outdated
| const createServer = (isHTTPS?: boolean) => { | ||
| const server = new Server(isHTTPS); | ||
| export const createServer = (isHTTPS?: boolean) => { | ||
| const a = new Server(isHTTPS); |
There was a problem hiding this comment.
What about doing just a return new Server(isHTTPS);? Not a huge fan of a
There was a problem hiding this comment.
Ups, I forgot to restore the name to server... but yes, maybe is better just do a return.
sarvaje
force-pushed
the
definition-files
branch
from
6c33663 to
edf8bda
Compare
molant
approved these changes
Aug 23, 2017
alrra
approved these changes
Aug 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #432