-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to add type definitions to npm package so we can create external rule/connector #432
Comments
@sarvaje what are the folders that should be added to the npm package? |
I'm not sure, in packages like |
I think that just the |
Anything in the |
If we try to create an external rule/connector, we don't have the type definitions, so typescript notifies some errors when they are not.
For example, if we try to create a new
Launcher
for a connector, I have to do something like:export class NewLauncher exports Launcher
Launcher
has a protected propertyport
, but if I try to use that property insideNewLauncher
I get a typescript errorerror TS2339: Property 'port' does not exist on type 'NewLauncher'.
The text was updated successfully, but these errors were encountered: