Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Move nullability inside WGPURenderPassDepthStencilAttachment #411

Closed
wants to merge 1 commit into from
Closed

Proposal: Move nullability inside WGPURenderPassDepthStencilAttachment #411

wants to merge 1 commit into from

Conversation

kainino0x
Copy link
Collaborator

@kainino0x kainino0x commented Nov 12, 2024 •
edited
Loading

fixes #408

@Kangz
Copy link
Collaborator

Kangz commented Nov 12, 2024

I'm not looking forward to doing all the changes for this, but either decision here seems fine. (IDK that it is strictly better than what we have now though).

@kainino0x
Copy link
Collaborator Author

It's more consistent with other structs, but given WGPURenderPassColorAttachment have to be a pointer (because they're an array), I don't feel that the consistency is very important, so I'm OK not doing this. Will close for now (issue is still on the agenda for discussion).

@kainino0x kainino0x closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kainino0x @Kangz