Add WGPUFeatureLevel #399
Merged
Add WGPUFeatureLevel #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lokokung
approved these changes
Nov 12, 2024
Kangz
reviewed
Nov 12, 2024
| /** | ||
| * "Feature level" for the adapter request. If an adapter is returned, it must support the features and limits in the requested feature level. | ||
| * | ||
| * Implementations may ignore @ref WGPUFeatureLevel_Compatibility and provide @ref WGPUFeatureLevel_Core instead. @ref WGPUFeatureLevel_Core is the default in the JS API, but in C, this field is **required** (must not be undefined). |
There was a problem hiding this comment.
Prior to this it would have been allowed to call wgpuInstanceRequestAdapter(instance, nullptr) to get any adapter that the instance chooses. Can't we say that it defaults to core like the JS API?
| typedef enum WGPUFeatureLevel { | ||
| /** | ||
| * `0x00000001`. | ||
| * "Compatibility" profile which can be supported on OpenGL ES 3.1. |
There was a problem hiding this comment.
I'm unclear on this, I thought we came to the conclusion D3D11 could actually support core? Or did that turn out not to be true?
There was a problem hiding this comment.
We guessed that maybe it is possible but we never tried. So for now it is safe to assume that D3D11 only provides compat.
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Dec 11, 2024
Spec PR: webgpu-native/webgpu-headers#399 Bug: 366151404 Change-Id: I3b684f1e4f72245b9adcf25d567b9d49c3ae27a3 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/218514 Reviewed-by: Kai Ninomiya <[email protected]> Commit-Queue: Fr <[email protected]>
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Dec 11, 2024
Spec PR: webgpu-native/webgpu-headers#399 Bug: 366151404 Change-Id: I6c19179b80bd20540080eee69b4ca9177bbd5caf Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/218534 Commit-Queue: Fr <[email protected]> Reviewed-by: Kai Ninomiya <[email protected]>
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Dec 11, 2024
Spec PR: webgpu-native/webgpu-headers#399 Bug: 366151404 Change-Id: I4d7ee2d4e2cf7bc73b8ba60f3c1d0652c5711aae Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/218535 Reviewed-by: Kai Ninomiya <[email protected]> Commit-Queue: Fr <[email protected]>
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Jan 2, 2025
Spec PR: webgpu-native/webgpu-headers#399 Bug: 366151404 Change-Id: I4be2afaaf4a92fbf0df0172e1a00f7db212f720f Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/220894 Reviewed-by: Loko Kung <[email protected]> Commit-Queue: Fr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also changed the struct order to go: required -> optional -> native-only optional.
Issue #293 - does not officially resolve it yet because we need to decide on defaulting.
(dawn bug https://crbug.com/378514251)