Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default feature level in the C API as well #412

Closed
Kangz opened this issue Nov 12, 2024 · 3 comments · Fixed by #435
Closed

Default feature level in the C API as well #412

Kangz opened this issue Nov 12, 2024 · 3 comments · Fixed by #435
Labels
has resolution Issue is resolved, just needs to be done

Comments

@Kangz
Copy link
Collaborator

Kangz commented Nov 12, 2024

Prior to this it would have been allowed to call wgpuInstanceRequestAdapter(instance, nullptr) to get any adapter that the instance chooses. Can't we say that it defaults to core like the JS API?

Originally posted by @Kangz in #399 (comment)

@kainino0x kainino0x added the !discuss Needs discussion (at meeting or online) label Nov 13, 2024
@kainino0x
Copy link
Collaborator

See #293 for past discussion, I'll close that one in favor of this more specific one.

@kainino0x
Copy link
Collaborator

Prior to this it would have been allowed to call wgpuInstanceRequestAdapter(instance, nullptr) to get any adapter that the instance chooses. Can't we say that it defaults to core like the JS API?

This is a good point, I forgot this means you have to pass a whole descriptor. I am fine with matching the JS API.

@kainino0x kainino0x added has resolution Issue is resolved, just needs to be done and removed !discuss Needs discussion (at meeting or online) labels Nov 23, 2024
@kainino0x
Copy link
Collaborator

kainino0x commented Nov 23, 2024

Nov 21 meeting:

  • KN: We previously discussed making Compatibility the default. Corentin prefers to default to Core to match JS. Kind of nice to make it required, but then the whole WGPURequestAdapterOptions struct becomes required. OTOH, non-breaking to add default later.
  • CF: wgpu doesn't really have compatibility mode but effectively defaults to Core. Would prefer to make this required, but can see the argument for defaulting to core. Have at times regretted the default to core in wgpu, but WebGPU is already more limited in its default device.
  • Default to core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has resolution Issue is resolved, just needs to be done
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants