Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds WGPUBool typedef. #210

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Adds WGPUBool typedef. #210

merged 2 commits into from
Aug 8, 2023

Conversation

lokokung
Copy link
Collaborator

@lokokung lokokung commented Aug 4, 2023

#84

@lokokung lokokung requested a review from kainino0x August 4, 2023 21:24
kainino0x
kainino0x reviewed Aug 5, 2023
View reviewed changes
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to bundle with the other changes to remove stdbool.h and usages of bool?

@lokokung
Copy link
Collaborator Author

lokokung commented Aug 7, 2023

Whoops, no, there's no reason it wasn't included. Updated now!

Beyley
Beyley approved these changes Aug 7, 2023
View reviewed changes
Copy link

@Beyley Beyley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from my end! should help smooth out bindings from C# (since bool in C# is generally marshalled as a 32-bit type for compat with the windows BOOL type, see this page UnmanagedType.Bool is 32-bit)

kainino0x
kainino0x approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kainino0x kainino0x merged commit 7fba7d0 into webgpu-native:main Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Beyley Beyley Beyley approved these changes

@kainino0x kainino0x kainino0x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lokokung @kainino0x @Beyley