Issues with C / C++ bool type. #84
Assignees
Labels
has resolution
Issue is resolved, just needs to be done
Comments
ghost
mentioned this issue
aarongable
pushed a commit
to chromium/chromium
that referenced
this issue
Aug 2, 2023
See https://chromium-review.googlesource.com/c/chromium/src/+/4740656 for Dawn-side changes. github.com/webgpu-native/webgpu-headers/issues/84 Change-Id: I524ec7ee1b8cb2e2834aa8c8a92388c5b74ca830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4740656 Reviewed-by: Kai Ninomiya <[email protected]> Commit-Queue: Loko Kung <[email protected]> Cr-Commit-Position: refs/heads/main@{#1178207}
|
is there an ETA for a fix landing in this repository? movement seems to be happening chromium side, but i dont see an open PR over here, should i open a PR for adding a typedef for WGPUBool? |
|
Yea this should be coming within the next week. I am trying to land the effective changes on Chromium side to make sure it will work there. I can create the corresponding PR here once that's progressed a bit more. |
Merged
wrench-bot
pushed a commit
to hexops-graveyard/dawn
that referenced
this issue
Aug 6, 2023
On Dawn side, this includes some compatibility changes so that it is ergonomic to use the new underlying bool type transparently. This change must wait for the following change(s) to land: - https://chromium-review.googlesource.com/c/chromium/src/+/4740656 github.com/webgpu-native/webgpu-headers/issues/84 Change-Id: Ie0f37dfc313ec32ae4aa5236ec0ecf4dab353923 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/144207 Kokoro: Kokoro <[email protected]> Commit-Queue: Loko Kung <[email protected]> Reviewed-by: Austin Eng <[email protected]> Reviewed-by: Kai Ninomiya <[email protected]>
aarongable
pushed a commit
to chromium/chromium
that referenced
this issue
Aug 8, 2023
This change must wait for the following change(s) to land and roll: - https://dawn-review.googlesource.com/c/dawn/+/144207 github.com/webgpu-native/webgpu-headers/issues/84 Change-Id: Iab5f80ee85442f8274cf388198be6605a0f37d2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4740397 Reviewed-by: Kai Ninomiya <[email protected]> Commit-Queue: Loko Kung <[email protected]> Cr-Commit-Position: refs/heads/main@{#1180618}
wrench-bot
pushed a commit
to hexops-graveyard/dawn
that referenced
this issue
Aug 10, 2023
This change should only land after the following change(s) land: - https://chromium-review.googlesource.com/c/chromium/src/+/4740397 github.com/webgpu-native/webgpu-headers/issues/84 Change-Id: I66b5eb077b678de4eff312b6628f0d9b54871867 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/144205 Commit-Queue: Loko Kung <[email protected]> Reviewed-by: Kai Ninomiya <[email protected]> Reviewed-by: Austin Eng <[email protected]> Kokoro: Kokoro <[email protected]>
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is an issue that someone (graphite?) raised on Discord but didn't file here. The
booltypes in C/C++ are kinda weird and can not match, especially when put back to back.webgpu.hshouldn't rely on this type, and instead do something like Vulkan'sVkBool32.The text was updated successfully, but these errors were encountered: