fix: allow for checking non-existent elements #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Good catch! |
christian-bromann
approved these changes
Aug 6, 2024
|
Hey goosewobbler 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at [email protected] or in the contributing channel on Discord. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
christian-bromann
pushed a commit
that referenced
this pull request
Aug 15, 2024
* fix: allow for checking non-existent elements * fix: support non-existent elements in matchers
christian-bromann
added a commit
that referenced
this pull request
Aug 15, 2024
* refactor: delete XXXContaining matchers (#1550) * refactor: delete toHaveUrlContaining * refactor: delete toHaveTitleContaining * refactor: delete toHaveClipboardTextContaining * refactor: delete toHaveAttributeContaining * refactor: delete toHaveElementClassContaining * refactor: delete toHaveValueContaining * refactor: delete toHaveComputedLabelContaining * refactor: delete toHaveComputedRoleContaining * refactor: delete toHaveHrefContaining * refactor: delete toHaveLinkContaining * refactor: delete toHaveTextContaining * refactor: delete toHaveHTMLContaining * docs: add stringContaining examples --------- Co-authored-by: Christian Bromann <[email protected]> * fixes after rebase * upgrade WebdriverIO to v9 * lower treshold as we punted on the body payload coverage * ci: update release pipeline * update version after failed release * Release 5.0.0-alpha.1 * fix peer deps * Release 5.0.0-alpha.2 * fix: allow for checking non-existent elements (#1623) * fix: allow for checking non-existent elements * fix: support non-existent elements in matchers * update deps * fix build --------- Co-authored-by: goosewobbler <[email protected]> Co-authored-by: WebdriverIO Release Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
wdio-electron-serviceDOM tests are failing on the non-existent element test. I traced the issue back to this line where an error is thrown when the target element does not exist.