Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): appEntryPoint #704

Merged
merged 78 commits into from
Aug 19, 2024
Merged

(feat): appEntryPoint #704

merged 78 commits into from
Aug 19, 2024

Conversation

goosewobbler
Copy link
Member

@goosewobbler goosewobbler commented Jul 24, 2024

Adding an appEntryPoint config setting to support apps which have not been built. Closes #331.

Also fixes Windows timeouts (#600) by splitting the E2Es across different runners.

TODO:

  • Fix E2Es
  • Fix Windows CI
  • Unit tests
  • Clean up
  • Docs
  • Fix expect-webdriver issue (waiting for updated WDIO v9 builds)

@goosewobbler goosewobbler linked an issue Jul 24, 2024 that may be closed by this pull request
@goosewobbler
Copy link
Member Author

goosewobbler commented Jul 24, 2024

Windows CI causing issues here, tests pass fine on my local Windows box.
Getting ERROR webdriver: AbortError: This operation was aborted when creating the webdriver session...

https://github.com/webdriverio-community/wdio-electron-service/actions/runs/10091326965/job/27902661012?pr=704#step:10:68

@christian-bromann Do you have any idea why this might be happening, or ideas for debug? The no-binary E2Es are running in serial, there shouldn't be any other process interfering with them, and they pass locally on Windows but not on Windows CI.

There are some issues updating fully to alpha.369 (see #685), I wonder if something there is the cause. I'll wait until the next WDIO v9 pre-release before raising an issue in the main repo regarding that, just in case it has already been fixed.

UPDATE: nvm, got them working by upgrading to the latest Electron and splitting the e2es over different Windows runners to avoid #600

@goosewobbler
Copy link
Member Author

goosewobbler commented Aug 6, 2024

Found the aforementioned issue with alpha.369 onwards - it's due to a change in expect-webdriverio. Raised webdriverio/expect-webdriverio#1623

@goosewobbler goosewobbler merged commit 8683003 into main Aug 19, 2024
10 checks passed
@goosewobbler goosewobbler deleted the sm/no-binary branch August 19, 2024 21:22
@christian-bromann
Copy link
Contributor

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows CI timeouts with Electron 30 Start electron without a binary (i.e. electron main.js)
2 participants