Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat): allow wdio config to be in a sub directory #206

Merged
merged 3 commits into from
Oct 9, 2023
Merged

(feat): allow wdio config to be in a sub directory #206

merged 3 commits into from
Oct 9, 2023

Conversation

christian-bromann
Copy link
Contributor

fixes #203

@goosewobbler
Copy link
Member

goosewobbler commented Oct 9, 2023 •
edited
Loading

I think this would be better tested in units by setting the rootDir as there are already tests and fixtures for reading electron versions from package.json, I updated for this, let me know what you think. Also, to fix the formatting I recommend installing the Prettier VSCode extension and setting format on save, alternatively you can just run pnpm format before push.

christian-bromann
christian-bromann commented Oct 9, 2023
View reviewed changes
Copy link
Contributor Author

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense 👍

Please go ahead, approve and merge when ready!

@goosewobbler goosewobbler merged commit c569fa9 into main Oct 9, 2023
3 checks passed
@christian-bromann christian-bromann deleted the cb/use-read-pkg-up branch October 9, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goosewobbler goosewobbler goosewobbler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Electron version not read from package.json if WDIO config is in a subdir
2 participants
@christian-bromann @goosewobbler