Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron version not read from package.json if WDIO config is in a subdir #203

Closed
christian-bromann opened this issue Oct 7, 2023 · 3 comments · Fixed by #206
Closed
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@christian-bromann
Copy link
Contributor

If the wdio.conf.js file is in a sub directory, the service won't find the Electron version automatically anymore because the config file is not located next to a package.json anymore. I suggest to use pkg-up to find the closest one.

@goosewobbler goosewobbler added the enhancement New feature or request label Oct 7, 2023
@goosewobbler goosewobbler added this to the v5.1.0 milestone Oct 7, 2023
@goosewobbler goosewobbler changed the title Do a look-up search for package.json Electron version not read from package.json if WDIO config is in a subdir Oct 7, 2023
@goosewobbler goosewobbler added the documentation Improvements or additions to documentation label Oct 8, 2023
@goosewobbler
Copy link
Member

goosewobbler commented Oct 8, 2023

Presumably we also want to use pkg-up in the docs and examples when finding the productName for passing to getBinaryPath.

@christian-bromann christian-bromann self-assigned this Oct 9, 2023
@christian-bromann
Copy link
Contributor Author

Is there any way we can assume a good default here and allow users to set only if desired. It would be amazing if users don't have to set anything if they follow the default setup.

I will look into this.

@goosewobbler
Copy link
Member

Let's just keep this issue about getting the electron version from package.json, the productName case is a different thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants