Fixes #2051: Remove type-stylo from EXTRA_LABELS allow-list #2573

suhailsinghbains · 2018-08-23T07:27:40Z

Fixes #2051

I removed type-stylo from config/init.py
I removed type-stylo from tests/unit/test_form.py
[Yes ] I have read the Pull Request + Code Style Guidelines thoroughly.

TravisBuddy · 2018-08-23T07:33:29Z

Travis tests have failed

Hey @suhailsinghbains,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

nosetests

Milestones are not initialized. Check logs.

sleep 5

$ npm run lint

> webcompat@ lint /home/travis/build/webcompat/webcompat.com
> npm run lint:js && npm run lint:css


> webcompat@ lint:js /home/travis/build/webcompat/webcompat.com
> eslint ./Gruntfile.js ./tests ./grunt-tasks ./webcompat/static/js/lib


> webcompat@ lint:css /home/travis/build/webcompat/webcompat.com
> stylelint './webcompat/static/css/src/**/*.css' './webcompat/static/css/webcompat.dev.css'


$ npm run build

> webcompat@ build /home/travis/build/webcompat/webcompat.com
> grunt

Running "checkDependencies:default" (checkDependencies) task

Running "jst:compile" (jst) task
File webcompat/static/js/dist/templates.js created.

Running "concat:dist" (concat) task

Running "concat:diagnose" (concat) task

Running "concat:issues" (concat) task

Running "concat:issueList" (concat) task

Running "concat:userActivity" (concat) task

Running "uglify:dist" (uglify) task
>> 1 file created 546.44 kB → 385.36 kB

Running "uglify:ga" (uglify) task
>> 1 file created 780 B → 585 B

Running "uglify:issues" (uglify) task
>> 1 file created 49.38 kB → 27.36 kB

Running "uglify:issueList" (uglify) task
>> 1 file created 37.72 kB → 20.17 kB

Running "uglify:userActivity" (uglify) task
>> 1 file created 21.05 kB → 11.03 kB

Running "uglify:diagnose" (uglify) task
>> 1 file created 12.9 kB → 6.44 kB

Running "uglify:contributors" (uglify) task
>> 1 file created 1.1 kB → 737 B

Running "postcss:dist" (postcss) task
>> 1 processed stylesheet created.

Running "cssmin:combine" (cssmin) task
>> 1 file created. 1.8 kB → 37.2 kB

Running "purifycss:target" (purifycss) task
Source Files:  [ 'webcompat/templates/about.html',
  'webcompat/templates/contact.html',
  'webcompat/templates/contributors.html',
  'webcompat/templates/error.html',
  'webcompat/templates/index.html',
  'webcompat/templates/issue.html',
  'webcompat/templates/layout.html',
  'webcompat/templates/list-issue.html',
  'webcompat/templates/new-issue.html',
  'webcompat/templates/privacy.html',
  'webcompat/templates/user-activity.html' ]
Source Files:  [ 'webcompat/templates/about.html',
  'webcompat/templates/contact.html',
  'webcompat/templates/contributors.html',
  'webcompat/templates/contributors/build-tools.html',
  'webcompat/templates/contributors/diagnose-bug.html',
  'webcompat/templates/contributors/organize-webcompat-events.html',
  'webcompat/templates/contributors/report-bug.html',
  'webcompat/templates/contributors/reproduce-bug.html',
  'webcompat/templates/contributors/site-outreach.html',
  'webcompat/templates/contributors/sub-nav.html',
  'webcompat/templates/contributors/web-platform-research.html',
  'webcompat/templates/dashboard/footer.html',
  'webcompat/templates/dashboard/layout.html',
  'webcompat/templates/dashboard/triage.html',
  'webcompat/templates/dashboard/triage/activity-indicator.html',
  'webcompat/templates/dashboard/triage/filters.html',
  'webcompat/templates/dashboard/triage/needstriage-list.html',
  'webcompat/templates/dashboard/triage/no-result.html',
  'webcompat/templates/dashboard/triage/stats.html',
  'webcompat/templates/dashboard/triage/top-bar.html',
  'webcompat/templates/error.html',
  'webcompat/templates/home-page/browse-issues.html',
  'webcompat/templates/home-page/form.html',
  'webcompat/templates/home-page/hero.html',
  'webcompat/templates/home-page/how-it-works.html',
  'webcompat/templates/home-page/join-us.html',
  'webcompat/templates/index.html',
  'webcompat/templates/issue.html',
  'webcompat/templates/issue/issue-aside.html',
  'webcompat/templates/issue/issue-comment-submit.html',
  'webcompat/templates/issue/issue-information.html',
  'webcompat/templates/layout.html',
  'webcompat/templates/list-issue.html',
  'webcompat/templates/list-issue/search-issue-filter.html',
  'webcompat/templates/nav/addon-links.html',
  'webcompat/templates/nav/nav.html',
  'webcompat/templates/nav/shared-nav-links.html',
  'webcompat/templates/nav/topbar.html',
  'webcompat/templates/new-issue.html',
  'webcompat/templates/privacy.html',
  'webcompat/templates/shared/footer.html',
  'webcompat/templates/shared/svg-icons.html',
  'webcompat/templates/user-activity.html',
  'webcompat/templates/user-activity/needsinfo.html',
  'webcompat/templates/user-activity/reported-by-user.html',
  'webcompat/templates/user-activity/user-mentions.html',
  'webcompat/templates/web_modules/pagination.html',
  'webcompat/templates/web_modules/tag.html' ]
Source Files:  [ 'webcompat/templates/issue/aside.jst',
  'webcompat/templates/issue/issue-comment-list.jst',
  'webcompat/templates/issue/issue-labels-sub.jst',
  'webcompat/templates/issue/issue-labels.jst',
  'webcompat/templates/issue/issue-milestones-sub.jst',
  'webcompat/templates/issue/issue-milestones.jst',
  'webcompat/templates/issue/metadata.jst',
  'webcompat/templates/issue/thanks.jst',
  'webcompat/templates/issue/upload-image.jst',
  'webcompat/templates/list-issue/dropdown.jst',
  'webcompat/templates/list-issue/issuelist-issue.jst',
  'webcompat/templates/list-issue/issuelist-search.jst',
  'webcompat/templates/list-issue/issuelist-sorting.jst',
  'webcompat/templates/web_modules/issue-list.jst',
  'webcompat/templates/web_modules/label-editor.jst',
  'webcompat/templates/web_modules/milestone-editor.jst' ]
Source Files:  []
Style Files:  [ 'webcompat/static/css/webcompat.dev.css' ]
Style Files:  [ 'webcompat/static/css/src/animations.css',
  'webcompat/static/css/src/bio.css',
  'webcompat/static/css/src/button.css',
  'webcompat/static/css/src/dropdown.css',
  'webcompat/static/css/src/filter-bar.css',
  'webcompat/static/css/src/filter.css',
  'webcompat/static/css/src/footer.css',
  'webcompat/static/css/src/form.css',
  'webcompat/static/css/src/grid.css',
  'webcompat/static/css/src/hero.css',
  'webcompat/static/css/src/icons.css',
  'webcompat/static/css/src/issue.css',
  'webcompat/static/css/src/issues-list.css',
  'webcompat/static/css/src/label-box.css',
  'webcompat/static/css/src/label-editor.css',
  'webcompat/static/css/src/labels.css',
  'webcompat/static/css/src/nav.css',
  'webcompat/static/css/src/notification-bar.css',
  'webcompat/static/css/src/pagination.css',
  'webcompat/static/css/src/sub-nav.css',
  'webcompat/static/css/src/tiles.css',
  'webcompat/static/css/src/typo.css',
  'webcompat/static/css/src/variables.css' ]

    ________________________________________________
    |
    |   PurifyCSS has reduced the file size by ~ 10.3%  
    |
    ________________________________________________
    

    ________________________________________________
    |
    |   PurifyCSS - Rejected selectors:  
    |   .visually-hidden
    |	.filter-bar-dropdown-listbox ul
    |	.filter-bar-dropdown-listbox a
    |	.filter-bar-dropdown-listbox a:focus
    |	:checked + label .collapsed-text
    |	.filter-bar-dropdown-input:not(:checked) + label .collapsed-text
    |	.filter-bar-dropdown-listbox
    |	:checked ~ .filter-bar-dropdown-listbox
    |	.filter-label .needscontact
    |	.filter-label .needscontact:hover
    |	.filter-label .needscontact.is-active
    |	.filter-label .sitewait
    |	.filter-label .sitewait:hover
    |	.filter-label .sitewait.is-active
    |	.form-upload:hover .visually-hidden
    |	.is-validated .check::after
    |	.is-validated.no-js-error .label-upload
    |	.is-validated.no-js-error:hover .label-upload
    |	.is-validated.no-js-error:focus-within .label-upload
    |	.is-validated .label-remove
    |	.is-validated:hover .icon-remove
    |	.is-validated:focus-within .icon-remove
    |	.is-validated:hover .label-remove .label-icon-message
    |	.is-validated:focus-within .label-remove .label-icon-message
    |	.label-editor-list-item.focused
    |	.label-editorLauncher
    |	.label-editorLauncher.is-active + .label-editor::after
    |	.label-editorLauncher.is-active + .label-editor
    |	.label-editor-launcher:hover
    |	.label-editor-launcher::before
    |	.label-editor-launcher.is-active::before
    |	.wc-Issue-categoryEditor-button .label-editorLauncher
    |	.issue.label-needscontact .x2
    |	.issue.label-sitewait .x2
    |	.label-box-header.label-needscontact
    |	.label-box-editor .label-needscontact
    |	.label-box-header.label-sitewait
    |	.label-box-editor .label-sitewait
    |	.label-box .label-editor-list .label-needscontact
    |	.label-box .label-editor-list .label-sitewait
    |	.is-offscreen
    |	.notification-bar
    |	.notification-information
    |	.notification-alert
    |	.notification-thanks
    |	.is-disabled
    |	.italic
    |	blockquote
    |
    ________________________________________________
    
File "tmp/purestyles.css" created.

Done.

$ pep8 --ignore=E402 webcompat/ tests/ config/secrets.py.example

$ nosetests
Milestones are not initialized. Check logs.

npm run test:js -- --reporters="runner" --firefoxBinary=`which firefox`

> webcompat@ test:js /home/travis/build/webcompat/webcompat.com
> node ./tests/functional/_intern.js "--reporters=runner" "--firefoxBinary=/home/travis/firefox-latest/firefox/firefox"

Error: 
        ======================================================
        Intern checkServer Connection Error: Error: connect ECONNREFUSED 127.0.0.1:5000
        ======================================================
        
  at ClientRequest.<anonymous>  <tests/functional/lib/setup.js:55:9>
  at emitOne  <events.js:116:13>
  at ClientRequest.emit  <events.js:211:7>
  at Socket.socketErrorListener  <_http_client.js:387:9>
  at emitOne  <events.js:116:13>
  at Socket.emit  <events.js:211:7>
  at emitErrorNT  <internal/streams/destroy.js:64:8>
something bad happened inside intern.run()
{ Error: 
        ======================================================
        Intern checkServer Connection Error: Error: connect ECONNREFUSED 127.0.0.1:5000
        ======================================================
        
    at ClientRequest.<anonymous> (/home/travis/build/webcompat/webcompat.com/tests/functional/lib/setup.js:55:9)
    at emitOne (events.js:116:13)
    at ClientRequest.emit (events.js:211:7)
    at Socket.socketErrorListener (_http_client.js:387:9)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at emitErrorNT (internal/streams/destroy.js:64:8)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9) reported: true }
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! webcompat@ test:js: `node ./tests/functional/_intern.js "--reporters=runner" "--firefoxBinary=/home/travis/firefox-latest/firefox/firefox"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the webcompat@ test:js script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2018-08-23T16_19_30_948Z-debug.log

suhailsinghbains · 2018-08-23T07:44:40Z

Hi @miketaylr I didn't understand why travis-ci failed, please could help me.
Thanks

karlcow · 2018-08-23T07:59:50Z

The travis failure is about two tests.
https://travis-ci.org/webcompat/webcompat.com/builds/419525686#L805-L830

karlcow

Thanks @suhailsinghbains

tests/unit/test_form.py

@@ -136,7 +136,7 @@ def test_get_metadata(self):
        form_object = MultiDict([
            ('reported_with', u'desktop-reporter'),
            ('url', u'http://localhost:5000/issues/new'),
-            ('extra_labels', [u'type-stylo', u'type-webrender-enabled']),
+            ('extra_labels', u'type-webrender-enabled'),


miketaylr · 2018-08-23T20:41:29Z

@suhailsinghbains tests are passing, thanks! I think if we could just squash the last 2 commits into a single commit with a commit message that refers to updating tests, we're good to merge here.

Do you know how to do that, or would you like some help?

suhailsinghbains · 2018-08-23T23:29:19Z

I'll search it and do that, otherwise would ping you.

miketaylr · 2018-08-24T19:34:35Z

I'll search it and do that, otherwise would ping you.

Cool! It looks like you nearly got there -- can you just add a reference to the issue number in the final commit? Then we're good to merge. 👍

suhailsinghbains · 2018-08-25T02:26:36Z

Okay, sure !

… a list

Comments have been addressed, r=me

miketaylr · 2018-08-29T18:35:59Z

Okay, sure !

Thank you! Sorry for the delay!

🎈

suhailsinghbains added 2 commits August 23, 2018 12:45

Fixes webcompat#2051: Remove type-stylo from EXTRA_LABELS allow-list

ce98fd6

Fixes webcompat#2051: Remove type-stylo from test_form.py

a6a3bce

karlcow previously requested changes Aug 23, 2018

View reviewed changes

suhailsinghbains force-pushed the issues/2051/1 branch from 718b2a8 to 3f4fc3d Compare August 23, 2018 23:39

Fixes webcompat#2051: Adding Square Brackets, as @extralabels expects…

5fd548a

… a list

suhailsinghbains force-pushed the issues/2051/1 branch from 3f4fc3d to 5fd548a Compare August 25, 2018 02:34

miketaylr approved these changes Aug 29, 2018

View reviewed changes

miketaylr merged commit 5060114 into webcompat:master Aug 29, 2018

miketaylr added the status: add to changelog label Aug 29, 2018

miketaylr removed status: add to changelog labels Sep 14, 2018

reinhart1010 mentioned this pull request Sep 16, 2018

New reports from Webcompat.com does not automatically assign browser labels #2580

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #2051: Remove type-stylo from EXTRA_LABELS allow-list #2573

Fixes #2051: Remove type-stylo from EXTRA_LABELS allow-list #2573

suhailsinghbains commented Aug 23, 2018 •

edited

Loading

TravisBuddy commented Aug 23, 2018 •

edited

Loading

suhailsinghbains commented Aug 23, 2018

karlcow commented Aug 23, 2018

karlcow left a comment

This comment was marked as abuse.

This comment was marked as abuse.

miketaylr commented Aug 23, 2018 •

edited

Loading

suhailsinghbains commented Aug 23, 2018

miketaylr commented Aug 24, 2018

suhailsinghbains commented Aug 25, 2018

miketaylr commented Aug 29, 2018

Fixes #2051: Remove type-stylo from EXTRA_LABELS allow-list #2573

Fixes #2051: Remove type-stylo from EXTRA_LABELS allow-list #2573

Conversation

suhailsinghbains commented Aug 23, 2018 • edited Loading

TravisBuddy commented Aug 23, 2018 • edited Loading

Travis tests have failed

1st Build

suhailsinghbains commented Aug 23, 2018

karlcow commented Aug 23, 2018

karlcow left a comment

Choose a reason for hiding this comment

This comment was marked as abuse.

This comment was marked as abuse.

miketaylr commented Aug 23, 2018 • edited Loading

suhailsinghbains commented Aug 23, 2018

miketaylr commented Aug 24, 2018

suhailsinghbains commented Aug 25, 2018

miketaylr commented Aug 29, 2018

suhailsinghbains commented Aug 23, 2018 •

edited

Loading

TravisBuddy commented Aug 23, 2018 •

edited

Loading

miketaylr commented Aug 23, 2018 •

edited

Loading