Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove type-stylo from EXTRA_LABELS #2051

Closed
miketaylr opened this issue Feb 6, 2018 · 5 comments
Closed

Remove type-stylo from EXTRA_LABELS #2051

miketaylr opened this issue Feb 6, 2018 · 5 comments
Labels
lang: Python prio: good first bug prio: important

Comments

@miketaylr
Copy link
Member

We no longer need to send it from Firefox:

https://reviewboard.mozilla.org/r/205210/diff/2#index_header
@miketaylr
Copy link
Member Author

miketaylr commented Feb 6, 2018 •
edited by zoepage
Loading

To fix this bug, remove the following line and send a PR!

@tanay1337 tanay1337 mentioned this issue Feb 6, 2018
Closed
@miketaylr
Copy link
Member Author

To fix this bug, remove the following line and send a PR!

Also, we need to fix some tests after changing that:

#2052 (comment)

@suhailsinghbains
Copy link

Hi @miketaylr I have read the PRs made and your comments on it, I know specifically what to do now. This would be my first bug in Python, can I please be assigned this issue.
Thanks.

@miketaylr
Copy link
Member Author

Hi @miketaylr I have read the PRs made and your comments on it, I know specifically what to do now. This would be my first bug in Python, can I please be assigned this issue.

Hi @suhailsinghbains! Apologies for the delay...

Please feel free to send in a pull request -- this issue is all yours!

@suhailsinghbains
Copy link

No worries, I'll try to solve ASAP.

suhailsinghbains pushed a commit to suhailsinghbains/webcompat.com that referenced this issue Aug 23, 2018
Fixes webcompat#2051: Remove type-stylo from EXTRA_LABELS allow-list
ce98fd6
suhailsinghbains pushed a commit to suhailsinghbains/webcompat.com that referenced this issue Aug 23, 2018
Fixes webcompat#2051: Remove type-stylo from test_form.py
a6a3bce
@suhailsinghbains suhailsinghbains mentioned this issue Aug 23, 2018
Merged
suhailsinghbains pushed a commit to suhailsinghbains/webcompat.com that referenced this issue Aug 25, 2018
Fixes webcompat#2051: Adding Square Brackets, as @extralabels expects…
5fd548a 
… a list
miketaylr pushed a commit that referenced this issue Aug 29, 2018
Merge pull request #2573 from suhailsinghbains/issues/2051/1
5060114 
Fixes #2051: Remove type-stylo from EXTRA_LABELS allow-list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lang: Python prio: good first bug prio: important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@miketaylr @zoepage @suhailsinghbains