Fixes #1862 - removes css-fixme #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlcow
reviewed
Nov 12, 2017
There was a problem hiding this comment.
Just a little style nit on quotes.
It could be good to rebase the linter fixes.
+1 to the rest from my point of view. Just commenting because I am awake before @miketaylr
Good job @zoepage
webcompat/views.py
Outdated
| This resource doesn't exist anymore. | ||
| See https://github.com/webcompat/css-fixme/ | ||
| for more details.""" | ||
| return (msg, 410, {"content-type": "text/plain; charset=utf-8"}) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
miketaylr
requested changes
Nov 13, 2017
webcompat/views.py
Outdated
| This resource doesn't exist anymore. | ||
| See https://github.com/webcompat/css-fixme/ | ||
| for more details.""" | ||
| return (msg, 410, {"content-type": "text/plain; charset=utf-8"}) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Thanks! I'm going to squash these into a single commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @miketaylr