Fixes #1862 - removes css-fixme

.gitignore

@@ -23,7 +23,6 @@ webcompat/static/js/diagnose.js
 webcompat/static/js/issues.js
 webcompat/static/js/issue-list.js
 webcompat/static/js/user-activity.js
-webcompat/static/js/cssfixme.js
 webcompat/static/js/templates.js
 webcompat/**/*.min.js
 webcompat/**/*.min.css

.travis.yml

@@ -38,7 +38,6 @@ install:
   - firefox --version
   # lint python
   - pep8 --ignore=E402 webcompat/ tests/ config/secrets.py.example
-  - npm run module
   - python run.py -t &
 
 before_script:

docs/dev-env-setup.md

@@ -51,8 +51,6 @@ We use [Grunt](http://gruntjs.com/) as a task runner to perform certain things (
 git clone https://github.com/<username>/webcompat.com.git #replace your github username
 # change to directory
 cd webcompat.com
-# check out submodules
-npm run module
 # initializing project
 npm run setup
 ```

grunt-tasks/concat.js

@@ -66,14 +66,6 @@ module.exports = function(grunt) {
         "<%= jsPath %>/lib/user-activity.js"
       ],
       dest: "<%= jsPath %>/user-activity.js"
-    },
-    cssFixmeLibs: {
-      src: [
-        "git_modules/css-fixme/js/css-browserside.js",
-        "git_modules/css-fixme/js/css-fixme.js",
-        "<%= jsPath %>/lib/css-fixme-ui.js"
-      ],
-      dest: "<%= jsPath %>/cssfixme.js"
     }
   });
 };

grunt-tasks/uglify.js

@@ -31,10 +31,6 @@ module.exports = function(grunt) {
     contributors: {
       src: "<%= jsPath %>/lib/contributors.js",
       dest: "<%= jsPath %>/contributors.min.js"
-    },
-    cssFixmeLibs: {
-      src: "<%= concat.cssFixmeLibs.dest %>",
-      dest: "<%= jsPath %>/cssfixme.min.js"
     }
   });
 };

package.json

@@ -52,7 +52,7 @@
     "stylelint-config-standard": "^16.0.0"
   },
   "scripts": {
-    "setup": "npm run module && npm run virtualenv && npm install && npm run config",
+    "setup": "npm run virtualenv && npm install && npm run config",
     "watch": "grunt watch",
     "build": "grunt",
     "jst": "grunt jst",
@@ -62,7 +62,6 @@
     "fix": "npm run lint:fix:JS",
     "lint:fix:JS": "eslint --fix ./Gruntfile.js ./tests ./grunt-tasks ./webcompat/static/js/lib",
     "imagemin": "grunt imagemin",
-    "module": "git submodule init && git submodule update",
     "prestart": "npm run build",
     "start": "source env/bin/activate || . env/bin/activate && python run.py",
     "start:test": "npm run build && source env/bin/activate || . env/bin/activate && python run.py -t",

tests/test_rendering.py

@@ -47,7 +47,6 @@ def test_titles(self):
             ('/', defaultTitle),
             ('/about', 'About'),
             ('/contributors', 'Contributors'),
-            ('/tools/cssfixme', 'CSS Fix Me'),
             ('/issues/' + issueNum, 'Issue #' + issueNum),
             ('/issues', 'Issues'),
             ('issues/new', 'New Issue'),

tests/test_urls.py

@@ -94,24 +94,13 @@ def test_csp_report_uri_bad_content_type(self):
     def test_tools_cssfixme(self):
         '''Test that the /tools/cssfixme route gets 200.'''
         rv = self.app.get('/tools/cssfixme')
-        self.assertEqual(rv.status_code, 200)
+        self.assertEqual(rv.status_code, 410)
 
     def test_rate_limit(self):
         '''Rate Limit URI sends 410 Gone.'''
         rv = self.app.get('/rate_limit')
         self.assertEqual(rv.status_code, 410)
 
-    def test_tools_cssfixme_with_URL(self):
-        '''Test that the /tools/cssfixme route gets 200 with ?url query.'''
-        url = '/tools/cssfixme?url=https://webcompat.com/css/webcompat.min.css'
-        rv = self.app.get(url)
-        self.assertEqual(rv.status_code, 200)
-
-    def test_tools_cssfixme_with_nonsense_URL(self):
-        '''Test that the /tools/cssfixme route gets 200 with bad ?url query.'''
-        rv = self.app.get('/tools/cssfixme?url=foobar')
-        self.assertEqual(rv.status_code, 200)
-
     def test_missing_parameters_for_new_issue(self):
         '''Sends 400 to POST on /issues/new with missing parameters.'''
         rv = self.app.post('/issues/new', data=dict(url='foo'))

webcompat/static/css/development/main.css

@@ -43,7 +43,6 @@
 @import "components/dropdown-header";
 @import "components/search-issue";
 @import "components/search-form";
-@import "components/cssfixme";
 @import "components/threesteps";
 @import "components/link";
 @import "components/github-link";

webcompat/views.py

@@ -280,7 +280,7 @@ def show_rate_limit():
     – Blade Runner
 
     This resource doesn't exist anymore."""
-    return (msg, 410, {"content-type": "text/plain; charset=utf-8"})
+    return (msg, 410, {'content-type': 'text/plain; charset=utf-8'})
 
 
 if app.config['LOCALHOST']:
@@ -330,8 +330,11 @@ def contributors():
 
 @app.route('/tools/cssfixme')
 def cssfixme():
-    """Route for CSS Fix me tool."""
-    return render_template('cssfixme.html')
+    msg = """
+    This resource doesn't exist anymore.
+    See https://github.com/webcompat/css-fixme/
+    for more details."""
+    return (msg, 410, {'content-type': 'text/plain; charset=utf-8'})
 
 
 @app.route('/csp-report', methods=['POST'])