Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1290 - change report bug link to new issues endpoint #1323

Merged
merged 1 commit into from
Feb 7, 2017

Conversation

zoepage
Copy link
Member

@zoepage zoepage commented Feb 2, 2017

@miketaylr miketaylr changed the title Issue #1290 - change report bug link to Fixes #1290 - change report bug link to Feb 2, 2017
@miketaylr miketaylr changed the title Fixes #1290 - change report bug link to Fixes #1290 - change report bug link to new issues endpoint Feb 2, 2017
@miketaylr
Copy link
Member

Sweet! Can you just update the commit message? Currently it's "Issue #1290 - change report bug link to". Something like "...link to new issue endpoint" or "...link to /issues/new"?

No need to send a new PR you can just do:

git commit --amend
...change commit message...
git push -f

But, you probably already knew that. 😄

(Also, ignore the test failure. Looks like the Intern 3 upgrade still has some warts. Tracking in #1324.)

Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(oops, forgot to leave my comment in this box...)

@zoepage
Copy link
Member Author

zoepage commented Feb 4, 2017

@miketaylr as you changed the title already, it's good or should I still change it to keep the history clean?

@miketaylr
Copy link
Member

@miketaylr as you changed the title already, it's good or should I still change it to keep the history clean?

Nope, no need to change the title -- but the commit should still get fixed up.

@zoepage
Copy link
Member Author

zoepage commented Feb 6, 2017

@miketaylr done. I hope, it's right this time :)

@zoepage zoepage dismissed miketaylr’s stale review February 6, 2017 21:32

commit msg was changed.

@miketaylr
Copy link
Member

Perfect, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants