Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all "built" scripts into a build folder #1834

Closed
miketaylr opened this issue Oct 3, 2017 · 7 comments
Closed

Move all "built" scripts into a build folder #1834

miketaylr opened this issue Oct 3, 2017 · 7 comments

Comments

@miketaylr
Copy link
Member

Basically everything that's not in js/lib or js/vendor should go into a js/build directory, and be git ignore'd. We should never edit those files, and it would be easier to hide them from editor search results as well.

@zoepage
Copy link
Member

zoepage commented Oct 3, 2017

This was already discussed in #1352, but I second that! Shall we do this now then (with grunt)?

@miketaylr
Copy link
Member Author

Yeah, why not. If and when webpack happens, it would mean less work to modify templates, etc.

@zoepage
Copy link
Member

zoepage commented Apr 16, 2018

@Regaddi is this something you'd be interested in? :)

@zoepage zoepage removed their assignment Apr 16, 2018
@Regaddi
Copy link
Member

Regaddi commented Apr 16, 2018

js/build is already in use and contains ga.js.
How about js/dist so we're consistent with css/dist?

@zoepage
Copy link
Member

zoepage commented Apr 16, 2018

+1

miketaylr pushed a commit that referenced this issue Apr 16, 2018
Issue #1834 - Move all generated JS files to js/dist
@mischah
Copy link
Member

mischah commented May 21, 2018

Isn’t this done and can be closed? 🤔

@miketaylr
Copy link
Member Author

Isn’t this done and can be closed? 🤔

Looks like it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants