-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1834 - Move all generated JS files to js/dist #2394
Conversation
Travis tests have failedHey @Regaddi, 1st Buildnpm run test:js -- --reporters="runner"
|
R? @miketaylr (to be sure we caught everything) |
(bummer, if #2385 was merged, we would have more info on this failure) |
@Regaddi you can just set a local environment variable: https://github.com/webcompat/webcompat.com/blob/master/config/environment.py#L19 |
grunt-tasks/concat.js
Outdated
@@ -25,15 +25,15 @@ module.exports = function(grunt) { | |||
"<%= jsPath %>/lib/bugform.js", | |||
"<%= jsPath %>/templates.js" |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
webcompat/**/*.min.js | ||
webcompat/**/**/*.min.css | ||
webcompat/static/js/*.js |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
grunt-tasks/concat.js
Outdated
@@ -25,15 +25,15 @@ module.exports = function(grunt) { | |||
"<%= jsPath %>/lib/bugform.js", | |||
"<%= jsPath %>/templates.js" | |||
], | |||
dest: "<%= jsPath %>/<%= pkg.name %>.js" | |||
dest: "<%= jsPath %>/dist/<%= pkg.name %>.js" |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Tests are green, LGTM! |
I think I caught all references, but don't know how to test locally because of
{%- if config.PRODUCTION or config.STAGING -%}
.Maybe someone has delightful input for me how to test PRODUCTION or STAGING locally 😄
r? @zoepage