Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pick up tree animation: Add new one click logic. #3082

Merged
merged 6 commits into from
May 30, 2022
Merged

Pick up tree animation: Add new one click logic. #3082

merged 6 commits into from
May 30, 2022

Conversation

gonnavis
Copy link
Contributor

Fix: #3010 (comment)

And finally the throw should not require hold, but only single tap to complete the throw

Related: #3010 (comment)

because of one click logics' structure is a blocker of this pr, so removed it first.
Will re-add it after refactored animation system.

I'm trying to refactor the animation system which each action/motion is a class instance and has animationEnd/finish event.

But I want to try another way in parallel that, because of we know the duration of pickUpThrow and other animations,
so animationEnd/finish event maybe not a must need.
Just check if useTime larger than known duration to run _endUse() is ok.
This is what this PR do.

@gonnavis gonnavis requested review from avaer and alisaad673 May 29, 2022 21:44
avaer
avaer approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@avaer avaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@avaer avaer merged commit 25c2184 into z-targeting May 30, 2022
@gonnavis gonnavis removed the request for review from alisaad673 May 30, 2022 03:28
@gonnavis gonnavis changed the title Pick up tree animation: Add one click logic. Pick up tree animation: Add new one click logic. May 30, 2022
@gonnavis gonnavis mentioned this pull request May 31, 2022
Closed
lalalune pushed a commit to TheNexusCity/webaverse-app that referenced this pull request Jun 9, 2022
Merge pull request webaverse#3082 from webaverse/Vis/PickUpTreePr
d0836fd 
Pick up tree animation: Add one click logic.
@alisaad673 alisaad673 mentioned this pull request Mar 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avaer avaer avaer approved these changes

Assignees
No one assigned
Labels
animation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gonnavis @avaer