Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pick up tree animation problem. #3010

Merged
merged 73 commits into from
May 26, 2022
Merged

Conversation

gonnavis
Copy link
Contributor

@gonnavis gonnavis commented May 17, 2022

Fix: #3060

Sibling PR: webaverse/plants#1

Fix pick up tree animation problem.

Before: Animation:
image

Before: Model: scilly_drophunter_v31_Guilty.vrm
image

After: Model: scilly_drophunter_v31.6_Guilty.vrm
image

After: Animation: Version1:

pick.up.version1.mp4

After: Animation: Version2:

pick.up.version2.mp4

@gonnavis gonnavis changed the base branch from master to z-targeting May 17, 2022 09:18
@gonnavis gonnavis marked this pull request as ready for review May 17, 2022 09:31
@gonnavis gonnavis requested a review from avaer May 17, 2022 09:32
@gonnavis gonnavis requested a review from avaer May 21, 2022 02:16
@gonnavis gonnavis requested a review from alisaad673 May 24, 2022 11:01
@gonnavis gonnavis linked an issue May 24, 2022 that may be closed by this pull request
@alisaad673
Copy link
Contributor

alisaad673 commented May 26, 2022

1-While we try to equip the tree, in the first try, the tree just falls down, while it gets picked up in the 2nd try. This is the case with all trees. Is it supposed to be this way?

2022-05-26.22-09-59.mp4

2-We are not covering the pickup animations while flying right?

2022-05-26.22-26-24.mp4

Other than these, seems to be a good start, Though imo animations can be improved later on like rn, the tree is being picked up from its bottom. that makes the long trees look unrealistic being picked up.
image

@gonnavis
Copy link
Contributor Author

gonnavis commented May 26, 2022

1-While we try to equip the tree, in the first try, the tree just falls down, while it gets picked up in the 2nd try. This is the case with all trees. Is it supposed to be this way?

It's original behavior, I think it's supposed to be.
But event not supposed to be, I think will not solve this problem in this pr, due to this pr is mainly focused on animation,

2-We are not covering the pickup animations while flying right?

Applied holding animation to fly.
But didn't apply thow animation, because it'll let codes way too complicated based on current animation system.
I'm refactoring animation system, should can handle this situation afterwards.

Before:
image

After:
image

the tree is being picked up from its bottom. that makes the long trees look unrealistic being picked up.

This should to be solved in plants repo.

And, because of one click logics' structure is a blocker of this pr, so removed it first.
Will re-add it after refactored animation system.

@avaer
Copy link
Contributor

avaer commented May 26, 2022

This should to be solved in plants repo.

Yeah the plants aren't done. This is just being used to test grab.

@avaer avaer merged commit aa43621 into webaverse:z-targeting May 26, 2022
lalalune pushed a commit to TheNexusCity/webaverse-app that referenced this pull request Jun 9, 2022
Fix pick up tree animation problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix pick up tree animation problem.
3 participants